Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.23.0 #46327

Merged
merged 3 commits into from
Dec 29, 2017
Merged

Updated RELEASES.md for 1.23.0 #46327

merged 3 commits into from
Dec 29, 2017

Conversation

XAMPPRocky
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2017

Misc
----
- [Releases now ship with the Cargo book documentation.][45692]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have to get yanked if #46195 isn't resolved

RELEASES.md Outdated
small files reduce the number of syscalls.

Stabilized APIs
---------------
Copy link
Member

@kennytm kennytm Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIs marked as since = "1.23":

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45990 didn't make it into 1.23.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ollie27 Thanks.

RELEASES.md Outdated
wide characters.][45711]
- [rustc now uses subtyping on the left hand side of binary operations.][45435]
Which should fix some confusing errors in some operations.
- [Bumped the minimum LLVM to 3.9][45326]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may better be a compatibility note?

RELEASES.md Outdated
- [Upgraded Android SDK to 27, and NDK to r15c.][45580] This drops support for
Android 9, the minimum supported version is Android 14.
- [Refactored type memory layouts and ABIs.][45225] This reduce code generated
for a lot of types.
Copy link
Member

@kennytm kennytm Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45225 should also be part of the Compiler section. I don't know about "code generated", as the most visible effect of #45225 is the reduced type size (e.g. size of Option<bool> is now 1 byte instead of 2 bytes; or more realistically, std::io::Result<()> is now 16 bytes long instead of 24 bytes).

RELEASES.md Outdated
Compiler
--------
- [Enabled `TrapUnreachable` in LLVM which should prevent some cases of
undefined behaviour.][45920]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more accurate to say that it mitigates the impact of the UB. This change doesn't make any programs defined that were previously UB, it just makes it more likely they trap at runtime instead of executing arbitrary code.

@mark-i-m
Copy link
Member

Woah... this is going to be a very large release if those are all release notes from the first week...

@steveklabnik
Copy link
Member

@mark-i-m no, they're from the previous six-week cycle; remember that we have the train model, so master is 1.24.

RELEASES.md Outdated
Libraries
---------
- [impl `From<T>` for `Mutex<T>` and `RwLock<T>`][46082]
- [Allow a trailling comma in `assert_eq/ne` macro][45887]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*trailing

RELEASES.md Outdated
for `AtomicU8`.
- [Removed the `T: Sync` requirement for `RwLock<T>: Send`][45267]
- [Removed `T: Sized` requirement for `<*const T>::as_ref`
and `<*const T>::as_mut`][44932]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be <*const T>::as_ref, <*mut T>::as_ref, and <*mut T>::as_mut.
(and not <*const T>::as_mut)

RELEASES.md Outdated

Language
--------
- [Fixed displaying duplicate errors on some trait bounds.][45772]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45772 is a language change - arbitrary auto traits are permitted in trait objects, but not displaying duplicate errors is not a language change.

RELEASES.md Outdated
- [rustc now suggests renaming import if names clash.][45660]
- [Display errors/warnings correctly when there are zero-width or
wide characters.][45711]
- [rustc now uses subtyping on the left hand side of binary operations.][45435]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of language change.

Copy link
Member

@ollie27 ollie27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#44042 and #45682 are also missing.

RELEASES.md Outdated
- [Implement Hash for raw pointers to unsized types][45483]
- [impl `From<*mut T>` for `AtomicPtr<T>`][45610]
- [impl `From<{number_size}>` for `Atomic{number_size}`][45610] eg. `From<u8>`
for `AtomicU8`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AtomicU8 isn't stable. This should only mention AtomicUsize and AtomicIsize.

RELEASES.md Outdated

Compatibility Notes
-------------------
- [`fmt::Arguments` can no longer be shared across threads.][45198]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't make it into 1.23.0.

RELEASES.md Outdated

Libraries
---------
- [impl `From<T>` for `Mutex<T>` and `RwLock<T>`][46082]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't make it into 1.23.0.

RELEASES.md Outdated
- [Optimized `Thread::{park, unpark}` implementation][45524]
- [Improved `SliceExt::binary_search` performance.][45333]
- [Optimized `Read::read_to_end`.][46050] This increase file read speed and for
small files reduce the number of syscalls.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't make it into 1.23.0.

RELEASES.md Outdated
in rare cases this could break some code.][45853] [Tracking issue for
further information][45852]
- [Changed how closures are stored, as a result of this change you can no longer
have a situation where a closure directly calls itself.][45879]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't make it into 1.23.0.

RELEASES.md Outdated
small files reduce the number of syscalls.

Stabilized APIs
---------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45990 didn't make it into 1.23.0.

@alexcrichton
Copy link
Member

Oh one important thing to call out maybe is that we're turning on 16 codegen units by default in debug builds, which should bring some nice parallellism wins to debug builds! (aka faster debug builds)

RELEASES.md Outdated
- [rustc now avoids unnecessary copies of arguments that are
simple bindings][45380] This should improve memory usage on average by 5-10%.
- [Updated musl used to build musl rustc to 1.1.17][45393]
- [Refactored type memory layouts and ABIs.][45225] This will reduce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #46925 is merged, please remove this item.

@alexcrichton
Copy link
Member

With the release going out soon, let's merge!

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 29, 2017

📌 Commit a1438b7 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2017
@XAMPPRocky
Copy link
Member Author

@alexcrichton I haven't added the note about 16 codegen units, I can't seem to find the PR that merges that in?

@bors
Copy link
Contributor

bors commented Dec 29, 2017

⌛ Testing commit a1438b7 with merge 19c656bf224f689401437b0e3ce7dd2da8d3abb6...

@alexcrichton
Copy link
Member

Oh heh looks like that happened in #44853 and was reduced to 16 in #45064, and turns out that's in 1.22!

@bors
Copy link
Contributor

bors commented Dec 29, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 29, 2017

@bors retry #40474

[00:06:08]  Downloading rand v0.3.18
[00:06:09]  Downloading regex v0.2.3

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@bors
Copy link
Contributor

bors commented Dec 29, 2017

⌛ Testing commit a1438b7 with merge 2dad872...

@bors
Copy link
Contributor

bors commented Dec 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2dad872 to master...

@bors bors merged commit a1438b7 into rust-lang:master Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.