Update RLS and Rustfmt #47051
Update RLS and Rustfmt #47051
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kennytm
added
the
S-waiting-on-review
|
Should this update rustfmt as well? |
|
I wanted to err on the safe side and update only RLS, mostly to fix the build issues. |
|
@kennytm how does the new https://github.com/rust-lang-nursery/rust-toolstate work? Does it automatically detect touched tools in the tree and publishes appropriate toolstate if it compiles/tests pass? |
|
Updated rustfmt submodule to rustfmt@0.3.4, which is the version that updated RLS uses. |
|
@Xanewok Yes it automatically detects if the tools can be built and tested. If the state changed, the CI will send a commit to update the webpage. Unfortunately if the update failed you need to send another PR to correct it 🤔 |
|
@bors r+ p=1 |
|
📌 Commit 5081b94 has been approved by |
Update RLS and Rustfmt Essentially #46929 with only RLS update that fixes the build. The rls wasn't included in the recent nightlies and a lot of people have been wondering what to do about it, so it'd be good to include the RLS back with the nightly builds as soon as we can. r? @alexcrichton
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@f0e5c95. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 🎉 rustfmt on windows: build-fail → test-pass. 🎉 rustfmt on linux: build-fail → test-pass.
Essentially #46929 with only RLS update that fixes the build.
The rls wasn't included in the recent nightlies and a lot of people have been wondering what to do about it, so it'd be good to include the RLS back with the nightly builds as soon as we can.
r? @alexcrichton