Improved error messages for linking failure #47052

fschutt · 2017-12-28T19:15:05Z

Partial fix for #46998

It's unnecessary to print the linker options if there is no linker installed in the first place. Currently, for libraries, the output is still printed, but that should be cleaned up in the future. If you don't have gcc or g++ installed, so that no linker is installed on the system, the output is now this:

$ ./rustc hello.rs
error: linker `cc` not found
  |
  = note: No such file or directory (os error 2)

error: aborting due to previous error

For libraries, the linker arguments are still printed, but they should be cleaned up in further commits.

rust-highfive · 2017-12-28T19:15:15Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

fschutt · 2017-12-28T19:26:32Z

Oh I see, I can't use TODO comments. I'll take them out for now.

estebank · 2017-12-28T21:17:07Z

@fschutt you'll need to modify compile-fail/issue-10755.rs to test for the new output ("linker llllll not found"). Could you also squash your commits?

r=me after the test is fixed.

fschutt · 2017-12-28T22:06:34Z

It's rebased now and test should be fixed.

I would say that the other things (like printing library paths, extra help, etc.) can be done in a seperate PR.

r? @estebank

estebank · 2017-12-29T00:11:11Z

@bors r+ rollup

bors · 2017-12-29T00:11:12Z

📌 Commit f78dd66 has been approved by estebank

bors · 2017-12-29T06:08:37Z

⌛ Testing commit f78dd66c77db34b92cba5499f30a699cdf6332fa with merge b889e175a36bf1d4bf371769bd3a0d1c5bfdd709...

bors · 2017-12-29T07:18:14Z

💔 Test failed - status-travis

fschutt · 2017-12-29T10:37:37Z

This is a problem in cargo, not rustc.

Basically, in src/tools/cargo/plugins.rs the line 284 is wrong:

    assert_that(bar.cargo("build").arg("--verbose"),
                execs().with_stderr_contains("\
[COMPILING] foo v0.0.1 ([..])
[RUNNING] `rustc [..] -C ar=nonexistent-ar -C linker=nonexistent-linker [..]`
[ERROR] could not exec the linker [..]
"));

... so the change in the error message breaks the build. Will do a seperate PR to cargo, because I think this is the only way to fix this.

fschutt · 2017-12-29T10:57:16Z

See rust-lang/cargo#4871

Update cargo tests for rust-lang/rust#47052 This test message currently breaks the build. The old error message was: ``` error: could not exec the linker `cc`: No such file or directory (os error 2) | = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "hello.hello0.rcgu.o" "hello.hello1.rcgu.o" "-o" "hello" "hello.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-d3700976135c3f09.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-8a207564cfc9f224.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-4712d699ce2d50e5.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-7224935811a361fe.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-3343c92f30e63266.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-6e8aafa8bd1a67de.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-a8b7c0565b6366c3.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_unicode-512049fc390dec2e.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-ba1f12eb6cef9a1a.rlib" "/home/felix/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-53aab67ab6317c59.rlib" "-Wl,-Bdynamic" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" error: aborting due to previous error ``` The new error message is: ``` error: linker `cc` not found | = note: No such file or directory (os error 2) error: aborting due to previous error ``` This currently breaks rust-lang/rust#47052. **NOTE:** I don't know if I handled the "ticks" around the linker name correctly (if cargo test is smart enough to see that the ticks are part of the omitted part). My reasoning was that in the rustc code the ticks are in the source and not part of the linkers name - so if rustc changes, this will probably break again. EDIT: fixed error message

fschutt · 2017-12-29T13:03:31Z

@bors r+

bors · 2017-12-29T13:03:31Z

@fschutt: 🔑 Insufficient privileges: Not in reviewers

fschutt · 2017-12-29T13:06:08Z

Sorry. The fix is merged in cargo now, I just wanted to retry.

kennytm · 2017-12-29T14:06:21Z

@bors r=estebank

bors · 2017-12-29T14:06:21Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Update RLS and Rustfmt #47051

bors · 2017-12-29T14:06:22Z

📌 Commit f78dd66 has been approved by estebank

bors · 2017-12-30T19:05:34Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: update books for next release #47076

bors · 2017-12-30T19:05:34Z

📌 Commit f78dd66 has been approved by estebank

bors · 2017-12-30T22:24:03Z

⌛ Testing commit f78dd66c77db34b92cba5499f30a699cdf6332fa with merge 7025aea940b8ac199e35a0ea197914848e5b81b9...

bors · 2017-12-30T23:51:27Z

💔 Test failed - status-appveyor

estebank · 2017-12-31T04:27:59Z

@fschutt the cargo dependency in this repo doesn't track master in the cargo repo, it has to be manually updated with a PR (like #47051). There was a file src/tools/toolstate.toml where you could mark one of these out of repo dependencies as broken, but I don't see it in master anymore, I'm not sure how it is supposed to work now. Do you want to create a PR updating cargo? Also, neat solution by making it compatible with both versions :)

kennytm · 2017-12-31T09:35:32Z

@estebank The new instructions for rls, rustfmt, miri and clippy are in https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#breaking-tools-built-with-the-compiler. Basically, the PR author doesn't need to care about these tools anymore. If they are broken after merging the PR, somebody else (the tool maintainers) can clean up the mess afterwards.

Cargo is unaffected by toolstate.toml though, before or now. It can never be broken.

@fschutt Since the "cargo fix" (rust-lang/cargo#4871) has already been merged on the cargo side, you just need to update the cargo submodule, and then create a separate PR or push a commit here.

cd src/tools/cargo
git checkout master
git pull origin master --ff-only
cd ../..
cargo update -p cargo
git add Cargo.lock tools/cargo
git ci -m 'Update cargo'

fschutt · 2017-12-31T14:41:41Z

@kennytm Done - should I squash this with the previous commit or rather leave it seperate? I'd personally leave it seperate so that it's clear when cargo was updated.

kennytm · 2017-12-31T14:48:34Z

@fschutt Keep it separate, thanks.

kennytm · 2017-12-31T16:41:25Z

@bors r=estebank rollup-

bors · 2017-12-31T16:41:26Z

📌 Commit aae8c29 has been approved by estebank

estebank · 2017-12-31T16:49:20Z

@bors r+

bors · 2017-12-31T16:49:21Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Use memchr to speed up [u8]::contains 3x #46713

bors · 2017-12-31T16:49:21Z

📌 Commit aae8c29 has been approved by estebank

bors · 2017-12-31T19:25:02Z

🔒 Merge conflict

fschutt · 2017-12-31T19:43:15Z

I'm not really sure where the merge conflict was ...

kennytm · 2017-12-31T20:10:46Z

@fschutt Maybe Cargo.lock or some other submodules. Please rebase on the latest master and see if git complains about anything.

# assume origin = https://github.com/rust-lang/rust.git
# and   fschutt = git@github.com:fschutt/rust.git
git pull origin master --rebase
git push fschutt master -f

…lled It's unnecessary to print the linker options if there is no linker installed. Currently, for libraries, the output is still printed, see #46998 for discussion

fschutt · 2017-12-31T21:52:59Z

Git said that there was a merge conflict in src/Cargo.lock, but it didn't show any conflicts, i.e. there were no conflict markers in the file. It just said that both branches (rustlang/rust and fschutt/rust) had modified the file. But no conflict markers.

I rebased and pushed as you said - Git did not complain about anything here, no merge conflict during the rebase. Hope this fixes it.

estebank · 2017-12-31T23:42:50Z

@bors r+

bors · 2017-12-31T23:42:51Z

📌 Commit 7c13fa3 has been approved by estebank

fschutt · 2017-12-31T23:54:55Z

happy new year, by the way

bors · 2018-01-01T01:00:30Z

⌛ Testing commit 7c13fa3 with merge 037bc65...

Improved error messages for linking failure Partial fix for #46998 It's unnecessary to print the linker options if there is no linker installed in the first place. Currently, for libraries, the output is still printed, but that should be cleaned up in the future. If you don't have gcc or g++ installed, so that no linker is installed on the system, the output is now this: ``` $ ./rustc hello.rs error: linker `cc` not found | = note: No such file or directory (os error 2) error: aborting due to previous error ``` For libraries, the linker arguments are still printed, but they should be cleaned up in further commits.

bors · 2018-01-01T04:09:46Z

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 037bc65 to master...

@ollie27

Add compiler docs testing to CI. Fixes #47025. I don't know if `x86_64-gnu` is the right builder for this, but there seems to be time left on [Travis](https://travis-ci.org/rust-lang/rust/jobs/307488864). Remaining problems blocking this PR: - [x] broken links caused by rustdoc issues: - [x] `pub use self::Enum::...`: #46766 and #46767 (fixed by #47050, thanks @ollie27!) - [x] `impl Deref for DerefToStdType`: #32129 (ignored in linkchecker) - [x] `#[feature(decl_macro)]` and `use std::vec`: #47038 (ignored in linkchecker) - [x] `rustc_data_structures::sync::{Lrc, RwLock}` aliases `std` types: #32130 (ignored in linkchecker) - [x] markdown differences, in rust repository and in external crates, now failing the build with #46880 merged (all fixed) - [x] multiple crate updates needed: `rand`, `log`, `parking_lot_core`, `flate2` - [x] submodule updates needed to deduplicate dependencies: `rust-installer`, ~`cargo`~ (done by #47052) - [x] #44953 test broken by `log` update (removed, this can be controversial) - [x] Waiting `x86_64-gnu` build results ([done](https://travis-ci.org/rust-lang/rust/builds/323451069)) See individual commits for more details.

rust-highfive assigned pnkfelix Dec 28, 2017

fschutt mentioned this pull request Dec 28, 2017

Unreadable error messages on linking failure #46998

Open

rust-highfive assigned estebank and unassigned pnkfelix Dec 28, 2017

fschutt mentioned this pull request Dec 29, 2017

Update cargo tests for https://github.com/rust-lang/rust/pull/47052 rust-lang/cargo#4871

Merged

fschutt closed this Dec 29, 2017

fschutt reopened this Dec 29, 2017

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 31, 2017

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2017

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2017

fschutt added 2 commits December 31, 2017 22:48

Removed unnecessary output of linker options when linker is not insta…

3e3536c

…lled It's unnecessary to print the linker options if there is no linker installed. Currently, for libraries, the output is still printed, see #46998 for discussion

Update cargo

7c13fa3

bors merged commit 7c13fa3 into rust-lang:master Jan 1, 2018

bors mentioned this pull request Jan 1, 2018

Add compiler docs testing to CI. #46278

Merged

10 tasks

kennytm mentioned this pull request Jan 1, 2018

Update RLS and Rustfmt and Cargo #46929

Closed

Improved error messages for linking failure #47052

Improved error messages for linking failure #47052

Conversation

fschutt commented Dec 28, 2017

rust-highfive commented Dec 28, 2017

fschutt commented Dec 28, 2017

estebank commented Dec 28, 2017

fschutt commented Dec 28, 2017

estebank commented Dec 29, 2017

bors commented Dec 29, 2017

bors commented Dec 29, 2017

bors commented Dec 29, 2017

fschutt commented Dec 29, 2017 • edited Loading

fschutt commented Dec 29, 2017

fschutt commented Dec 29, 2017

bors commented Dec 29, 2017

fschutt commented Dec 29, 2017

kennytm commented Dec 29, 2017 • edited Loading

bors commented Dec 29, 2017

bors commented Dec 29, 2017

bors commented Dec 30, 2017

bors commented Dec 30, 2017

bors commented Dec 30, 2017

bors commented Dec 30, 2017

estebank commented Dec 31, 2017

kennytm commented Dec 31, 2017 • edited Loading

fschutt commented Dec 31, 2017

kennytm commented Dec 31, 2017 • edited Loading

kennytm commented Dec 31, 2017

bors commented Dec 31, 2017

estebank commented Dec 31, 2017

bors commented Dec 31, 2017

bors commented Dec 31, 2017

bors commented Dec 31, 2017

fschutt commented Dec 31, 2017

kennytm commented Dec 31, 2017

fschutt commented Dec 31, 2017 • edited Loading

estebank commented Dec 31, 2017

bors commented Dec 31, 2017

fschutt commented Dec 31, 2017

bors commented Jan 1, 2018

bors commented Jan 1, 2018

fschutt commented Dec 29, 2017 •

edited

Loading

kennytm commented Dec 29, 2017 •

edited

Loading

kennytm commented Dec 31, 2017 •

edited

Loading

kennytm commented Dec 31, 2017 •

edited

Loading

fschutt commented Dec 31, 2017 •

edited

Loading