Skip to content

Defocus search bar in rustdoc pages #47134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Jan 3, 2018
Merged

Defocus search bar in rustdoc pages #47134

merged 2 commits into from Jan 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2018

@Sogomn
Defocus search bar in rustdoc pages
0772b6f 
Escape now removes focus from the search bar
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Sogomn
Indentation fix
3153d23 
Fixed intentaion (tabs -> spaces)
Added trailing newline
@QuietMisdreavus
Copy link
Member

(Let's try that again... >_>)

@bors r+ rollup

Thanks so much! I guess i totally got used to this not happening, but i'm glad you were able to get this in.

@bors
Copy link
Collaborator

bors commented Jan 2, 2018

📌 Commit 3153d23 has been approved by QuietMisdreavus

kennytm added a commit to kennytm/rust that referenced this pull request Jan 3, 2018
@kennytm
Rollup merge of rust-lang#47134 - Sogomn:master, r=QuietMisdreavus
08501bd 
Defocus search bar in rustdoc pages

rust-lang/rfcs#2265
@kennytm kennytm mentioned this pull request Jan 3, 2018
Merged
bors added a commit that referenced this pull request Jan 3, 2018
@bors
Auto merge of #47151 - kennytm:rollup, r=kennytm
b107f72 
Rollup of 9 pull requests

- Successful merges: #47104, #47107, #47113, #47117, #47118, #47121, #47125, #47134, #47145
- Failed merges:
@bors bors merged commit 3153d23 into rust-lang:master Jan 3, 2018
@ghost ghost mentioned this pull request Jan 4, 2018
Closed
@GuillaumeGomez
Copy link
Member

It's not working at all for me... I make a quick fix.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 5, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47202 - GuillaumeGomez:fix-defocus, r=Quiet…
b310417 
…Misdreavus

Fix search bar defocus

Fixes rust-lang#47134.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rust-highfive @QuietMisdreavus @bors @GuillaumeGomez @Sogomn