Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document when LineWriter flushes; document errors for into_inner. #47145

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Document when LineWriter flushes; document errors for into_inner. #47145

merged 1 commit into from
Jan 3, 2018

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 2, 2018

Fixes #42468.

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 3, 2018

r? @QuietMisdreavus

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

Tangentially, how have i not known about LineWriter until now? >_>

@bors
Copy link
Collaborator

bors commented Jan 3, 2018

📌 Commit f3ef077 has been approved by QuietMisdreavus

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 3, 2018

same here! i had no idea it existed until today

kennytm added a commit to kennytm/rust that referenced this pull request Jan 3, 2018
@kennytm
Rollup merge of rust-lang#47145 - frewsxcv:frewsxcv-linewriter-error,…
b416119 
… r=QuietMisdreavus

Document when LineWriter flushes; document errors for into_inner.

Fixes rust-lang#42468.
@kennytm kennytm mentioned this pull request Jan 3, 2018
Merged
bors added a commit that referenced this pull request Jan 3, 2018
@bors
Auto merge of #47151 - kennytm:rollup, r=kennytm
b107f72 
Rollup of 9 pull requests

- Successful merges: #47104, #47107, #47113, #47117, #47118, #47121, #47125, #47134, #47145
- Failed merges:
@bors bors merged commit f3ef077 into rust-lang:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @QuietMisdreavus @bors @shepmaster