Add NLL test for #45045 #47456
Merged
Add NLL test for #45045 #47456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnkfelix
reviewed
Jan 16, 2018
| let g = f; | ||
| match e { | ||
| Xyz::A => println!("a"), | ||
| //~^ cannot use `e` because it was mutably borrowed [E0503] |
There was a problem hiding this comment.
huh... the error message points at the first arm, not the use of e in match e itself on line 24? I wonder if we should consider that a bug...
There was a problem hiding this comment.
Huh, good question. I can see it being surprising, though of course it also makes sense. Obviously it'd be a separate thing to fix though
nikomatsakis
approved these changes
Jan 16, 2018
| let g = f; | ||
| match e { | ||
| Xyz::A => println!("a"), | ||
| //~^ cannot use `e` because it was mutably borrowed [E0503] |
There was a problem hiding this comment.
Huh, good question. I can see it being surprising, though of course it also makes sense. Obviously it'd be a separate thing to fix though
|
@bors r+ |
|
📌 Commit f9e1b9c has been approved by |
kennytm
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
Add NLL test for rust-lang#45045 cc rust-lang#45045 Part of rust-lang#47366 r? @nikomatsakis
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
Add NLL test for rust-lang#45045 cc rust-lang#45045 Part of rust-lang#47366 r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #45045
Part of #47366
r? @nikomatsakis