Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NLL test for #45045 #47456

Merged
merged 1 commit into from
Jan 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/test/ui/nll/borrowed-match-issue-45045.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Regression test for issue #45045

#![feature(nll)]

enum Xyz {
A,
B,
}

fn main() {
let mut e = Xyz::A;
let f = &mut e;
let g = f;
match e {
Xyz::A => println!("a"),
//~^ cannot use `e` because it was mutably borrowed [E0503]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh... the error message points at the first arm, not the use of e in match e itself on line 24? I wonder if we should consider that a bug...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, good question. I can see it being surprising, though of course it also makes sense. Obviously it'd be a separate thing to fix though

Xyz::B => println!("b"),
};
*g = Xyz::B;
}
11 changes: 11 additions & 0 deletions src/test/ui/nll/borrowed-match-issue-45045.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
error[E0503]: cannot use `e` because it was mutably borrowed
--> $DIR/borrowed-match-issue-45045.rs:25:9
|
22 | let f = &mut e;
| ------ borrow of `e` occurs here
...
25 | Xyz::A => println!("a"),
| ^^^^^^ use of borrowed `e`

error: aborting due to previous error