Upgrade env_logger #47501

sfackler · 2018-01-16T21:07:49Z

This restores module names to the logging output

rust-highfive · 2018-01-16T21:07:52Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

sfackler · 2018-01-16T21:09:02Z

cc @nikomatsakis

r? @alexcrichton

alexcrichton · 2018-01-16T22:17:18Z

@KodrAus mentioned that env_logger is close to an 0.5 release (like in the next day or two), so r=me if we hold out for that and then update here.

kennytm · 2018-01-17T09:32:46Z

env_logger 0.5.0 has been released. https://crates.io/crates/env_logger

nikomatsakis · 2018-01-17T17:18:30Z

my hero

sfackler · 2018-01-17T17:42:00Z

Updated!

alexcrichton · 2018-01-17T17:44:43Z

Urgh. By pulling in winapi 0.3 this'll be blocked on #47280. I wonder though if that could be avoided for now?

kennytm · 2018-01-17T17:49:29Z

I think the winapi 0.3 problem won't affect this PR since cargo is not updated.

The winapi dependency chain is:

env_logger 0.5.0 ← chrono 0.4.0 ← time 0.1.39 ← winapi 0.3.3

If we downgrade time to 0.1.38 it will depend on winapi 0.2 instead.

alexcrichton · 2018-01-17T17:55:09Z

@kennytm unfortunately it was a problem if winapi is anywhere in the crate dependency graph, not just as a direct dependency :(

sfackler · 2018-01-17T17:59:48Z

We could manually downgrade time to a version that pulled in winapi 0.2. It might be a bit fragile to maintain though.

kennytm · 2018-01-17T18:00:50Z

@alexcrichton Oh that's bad :(

So we need to stick a time = "=0.1.38" constraint somewhere, or is there any command to force the generated Cargo.lock to choose time = "=0.1.38"?

kennytm · 2018-01-17T18:01:45Z

@sfackler It is just a temporary measure, after #47280 there should be no problem using winapi 0.3

alexcrichton · 2018-01-17T18:01:57Z

@sfackler yeah that's fine for now, this is just a temporary problem until #47280 lands which is for sure to happen, I'd just want to uncouple these two changes for now.

alexcrichton · 2018-01-17T18:02:13Z

@kennytm we could have a constraint or just use cargo update -p time --precise 0.1.38

sfackler · 2018-01-17T18:04:20Z

Updated.

(If you find yourself needing to do this again for whatever reason, the magic phrase is cargo update -p time --precise 0.1.38)

alexcrichton · 2018-01-17T18:04:56Z

@bors: r+

bors · 2018-01-17T18:04:57Z

📌 Commit da00ea3 has been approved by alexcrichton

frewsxcv · 2018-01-21T03:08:17Z

@bors rollup

kennytm · 2018-01-21T17:01:33Z

@bors r-

This PR brings in chrono 0.4.0 as a dependency. When documenting this package (the strftime module) as part of the compiler, it was found to contain rendering difference between pulldown and hoedown.

I believe this is because hoedown/pulldown doesn't format to the same HTML.

[01:43:21] WARNING: documentation for this crate may be rendered differently using the new Pulldown renderer.
[01:43:21]     See https://github.com/rust-lang/rust/issues/44229 for details.
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[0]/td[1] One element is missing: expected: `strong`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[0] Unexpected element `td`: found: `<td><strong>DATE SPECIFIERS:</strong></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[4] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[4] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[9] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[9] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[12] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[12] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[17] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[17] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[20] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[20] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[24] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[24] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[26] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[26] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[31] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[31] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[32]/td[1] One element is missing: expected: `strong`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[32] Unexpected element `td`: found: `<td><strong>TIME SPECIFIERS:</strong></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[37] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[37] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[40] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[40] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[48] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[48] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[53] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[53] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[54]/td[1] One element is missing: expected: `strong`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[54] Unexpected element `td`: found: `<td><strong>TIME ZONE SPECIFIERS:</strong></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[58] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[58] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[59]/td[1] One element is missing: expected: `strong`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[59] Unexpected element `td`: found: `<td><strong>DATE &amp; TIME SPECIFIERS:</strong></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[62] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[62] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[64] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[64] Unexpected element `td`: found: `<td></td>`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[65]/td[1] One element is missing: expected: `strong`
[01:43:21] WARNING: rendering difference in ``strftime`/`strptime`-inspired date and time formatting syntax.`
[01:43:21]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.0/src/format/strftime.rs:4:0
[01:43:21]     /html[0]/body[0]/table[0]/tbody[0]/tr[65] Unexpected element `td`: found: `<td><strong>SPECIAL SPECIFIERS:</strong></td>`
[01:43:21] Aborting with 1 rendering differences
[01:43:21] �[m�[m�[31m�[1merror:�[m Could not document `chrono`.

cc @GuillaumeGomez. ~~I think we should fix pulldown or hoedown, instead of requiring chrono to update the docs.~~ Never mind, the rendering difference is legit. chrono should switch to that table syntax with a leading |.

kennytm · 2018-01-21T18:53:52Z

Now blocked by either:

chrono 0.4.1 gets released to include Fix a markdown rendering difference warning. chronotope/chrono#211, or
we ignore the markdown warnings when documenting the compiler.

bors · 2018-01-23T20:00:13Z

☔ The latest upstream changes (presumably #47678) made this pull request unmergeable. Please resolve the merge conflicts.

kennytm · 2018-01-25T20:00:44Z

env_logger has been updated to 0.5.3 in #47729, so this PR should not be needed anymore. Closing.

alexcrichton · 2018-01-25T20:01:50Z

@kennytm oh note that the update there was just for Cargo not for rustc, so we may still need this for rustc itself?

kennytm · 2018-01-25T20:02:33Z

Err sorry @alexcrichton you're right, missed the rest of the changes.

Still this needs a rebase, and #47501 (comment).

alexcrichton · 2018-03-05T21:40:02Z

I'm gonna close this in favor of #48642 in the hopes that it gets through

rust-highfive assigned estebank Jan 16, 2018

rust-highfive assigned alexcrichton and unassigned estebank Jan 16, 2018

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2018

sfackler force-pushed the env-logger-bump branch from 501c848 to 16db048 Compare January 17, 2018 17:42

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2018

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2018

kennytm removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2018

GuillaumeGomez mentioned this pull request Jan 21, 2018

Rollup of 7 pull requests #47636

Closed

kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2018

kennytm mentioned this pull request Jan 21, 2018

Fix a markdown rendering difference warning. chronotope/chrono#211

Merged

kennytm mentioned this pull request Jan 23, 2018

Update rls #47676

Merged

kennytm closed this Jan 25, 2018

kennytm reopened this Jan 25, 2018

shepmaster added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 3, 2018

pietroalbini added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 12, 2018

pietroalbini added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 19, 2018

pietroalbini added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 26, 2018

kennytm mentioned this pull request Mar 1, 2018

Update env_logger to 0.5.4 #48642

Merged

pietroalbini added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 5, 2018

alexcrichton closed this Mar 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade env_logger #47501

Upgrade env_logger #47501

sfackler commented Jan 16, 2018

rust-highfive commented Jan 16, 2018

sfackler commented Jan 16, 2018

alexcrichton commented Jan 16, 2018

kennytm commented Jan 17, 2018

nikomatsakis commented Jan 17, 2018

sfackler commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

kennytm commented Jan 17, 2018 •

edited

Loading

alexcrichton commented Jan 17, 2018

sfackler commented Jan 17, 2018

kennytm commented Jan 17, 2018 •

edited

Loading

kennytm commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

sfackler commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

bors commented Jan 17, 2018

frewsxcv commented Jan 21, 2018

kennytm commented Jan 21, 2018 •

edited

Loading

kennytm commented Jan 21, 2018

bors commented Jan 23, 2018

kennytm commented Jan 25, 2018

alexcrichton commented Jan 25, 2018

kennytm commented Jan 25, 2018 •

edited

Loading

alexcrichton commented Mar 5, 2018

Upgrade env_logger #47501

Upgrade env_logger #47501

Conversation

sfackler commented Jan 16, 2018

rust-highfive commented Jan 16, 2018

sfackler commented Jan 16, 2018

alexcrichton commented Jan 16, 2018

kennytm commented Jan 17, 2018

nikomatsakis commented Jan 17, 2018

sfackler commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

kennytm commented Jan 17, 2018 • edited Loading

alexcrichton commented Jan 17, 2018

sfackler commented Jan 17, 2018

kennytm commented Jan 17, 2018 • edited Loading

kennytm commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

sfackler commented Jan 17, 2018

alexcrichton commented Jan 17, 2018

bors commented Jan 17, 2018

frewsxcv commented Jan 21, 2018

kennytm commented Jan 21, 2018 • edited Loading

kennytm commented Jan 21, 2018

bors commented Jan 23, 2018

kennytm commented Jan 25, 2018

alexcrichton commented Jan 25, 2018

kennytm commented Jan 25, 2018 • edited Loading

alexcrichton commented Mar 5, 2018

kennytm commented Jan 17, 2018 •

edited

Loading

kennytm commented Jan 17, 2018 •

edited

Loading

kennytm commented Jan 21, 2018 •

edited

Loading

kennytm commented Jan 25, 2018 •

edited

Loading