Update rls #47676
Merged
Update rls #47676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
previously requested changes
Jan 23, 2018
src/Cargo.lock
Outdated
| @@ -265,6 +265,15 @@ name = "cfg-if" | |||
| version = "0.1.2" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
|
|
|||
| [[package]] | |||
| name = "chrono" | |||
| version = "0.4.0" | |||
There was a problem hiding this comment.
Could you not upgrade env_logger, to avoid conflict with #47501 (which is currently blocked due to )?chrono 0.4.0 prevents compiler doc from being warning-free
kennytm
added
the
S-waiting-on-review
kennytm
dismissed
their stale review
The env_logger change has been included in #47729, which will conflict with this PR. Please rebase on the latest master.
|
@bors: r+ p=1 Let's get the rls back in nightly! |
|
📌 Commit e6e436b has been approved by |
|
🔒 Merge conflict |
topecongiro
force-pushed
the
update-rls
branch
from
e6e436b
to
8636d01
Compare
|
Rebased on the latest master to resolve conflicts. |
|
@bors r=alexcrichton p=1 |
|
📌 Commit 8636d01 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 26, 2018
Update rls Currently rls is missing from the latest nightly component. This PR brings it back.
|
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 26, 2018
Tested on commit rust-lang/rust@5669050. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rls is missing from the latest nightly component. This PR brings it back.