-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLL test for mutating &mut references #47609
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Should this be replacing this test? |
Hmm, yes, a good point! Maybe we already had the test? I like how this test actually runs the result, though. @ritiek care to merge the two tests? |
Sure! Where should we keep the merged test though? |
@ritiek I prefer the |
44b6f0e
to
06d123d
Compare
OK. So now we have the merged test in |
📌 Commit 06d123d has been approved by |
@bors rollup |
…nikomatsakis NLL test for mutating &mut references As mentioned in rust-lang#46361. cc @nikomatsakis?
…nikomatsakis NLL test for mutating &mut references As mentioned in rust-lang#46361. cc @nikomatsakis?
As mentioned in #46361.
cc @nikomatsakis?