Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for documentation error issue 47716 #47717

Merged
merged 1 commit into from
Jan 25, 2018
Merged

fix for documentation error issue 47716 #47717

merged 1 commit into from
Jan 25, 2018

Conversation

evelynmitchell
Copy link
Contributor

@evelynmitchell evelynmitchell commented Jan 24, 2018 •
edited by kennytm
Loading

Fix #47716

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

r? @steveklabnik

cc @rust-lang/docs

@kennytm kennytm added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2018
@steveklabnik
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit 05652d2 has been approved by steveklabnik

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 25, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47717 - evelynmitchell:47716-doc-fix, r=ste…
f72d441 
…veklabnik

fix for documentation error issue 47716

Fix rust-lang#47716
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47717 - evelynmitchell:47716-doc-fix, r=ste…
f769b9d 
…veklabnik

fix for documentation error issue 47716

Fix rust-lang#47716
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 25, 2018
Merged
bors added a commit that referenced this pull request Jan 25, 2018
@bors
Auto merge of #47740 - GuillaumeGomez:rollup, r=GuillaumeGomez
9fd7da9 
Rollup of 10 pull requests

- Successful merges: #47534, #47609, #47679, #47691, #47700, #47702, #47717, #47721, #47726, #47729
- Failed merges:
@bors bors merged commit 05652d2 into rust-lang:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evelynmitchell @rust-highfive @GuillaumeGomez @steveklabnik @bors @kennytm