Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call non-git beta builds simply x.y.z-beta #47762

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 26, 2018

We can't use git commands to compute a prerelease version when we're
building from a source tarball, or if git is otherwise unavailable.
We'll just call such builds x.y.z-beta, without a prerelease.

Fixes #47754
r? @alexcrichton

We can't use git commands to compute a prerelease version when we're
building from a source tarball, or if git is otherwise unavailable.
We'll just call such builds `x.y.z-beta`, without a prerelease.
@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 26, 2018

📌 Commit a76bb88 has been approved by alexcrichton

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jan 26, 2018
@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 26, 2018
@bors bors merged commit a76bb88 into rust-lang:master Jan 26, 2018
@cuviper cuviper deleted the beta-prerelease branch January 26, 2018 21:27
@MaloJaffre MaloJaffre mentioned this pull request Feb 1, 2018
bors added a commit that referenced this pull request Feb 1, 2018
bors added a commit that referenced this pull request Feb 2, 2018
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants