Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-installer #48669

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Mar 2, 2018

This removes the last dependency on rayon 0.9

This removes the last dependency on rayon 0.9
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Eijebong
Copy link
Contributor Author

Eijebong commented Mar 2, 2018

Actually, I didn't see it before but the installer has a lot of outdated dependencies. It might be a better idea to wait for those to be bumped (working on it right now).

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 2, 2018

📌 Commit 75fd910 has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2018
Removes the walkdir 1.0 and same-file 0.1 dependencies
@Eijebong
Copy link
Contributor Author

Eijebong commented Mar 2, 2018

@alexcrichton I repushed a second bump now that all dependencies are up to date in rust-installer

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 2, 2018

📌 Commit 4858065 has been approved by alexcrichton

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 3, 2018
@alexcrichton
Copy link
Member

@bors: rollup

bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
@alexcrichton alexcrichton merged commit 4858065 into rust-lang:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants