Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor away inferred_obligations from the trait selector #48710

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Refactor away inferred_obligations from the trait selector #48710

merged 1 commit into from
Mar 8, 2018

Conversation

aravind-pg
Copy link
Contributor

A small refactoring that removes the inferred_obligations field from SelectionContext in the trait selector in favor of threading nested obligations around explicitly. Closes #48672.

r? @nikomatsakis

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2018

📌 Commit 81f0b96 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
@nikomatsakis
Copy link
Contributor

Just for reference, @aravind-pg and I had a short conversation on gitter where I pointed out that this may change behavior slightly, but it seems like the existing behavior was a bug and I think in practice it wouldn't have any effect anyway.

@alexcrichton alexcrichton mentioned this pull request Mar 7, 2018
Merged
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
6675913 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
29d7fc1 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
bors added a commit that referenced this pull request Mar 7, 2018
@bors
Auto merge of #48806 - alexcrichton:rollup, r=alexcrichton
5430c0c 
Rollup of 9 pull requests

- Successful merges: #48511, #48549, #48618, #48624, #48651, #48698, #48778, #48787, #48802
- Failed merges: #48669, #48710
@alexcrichton alexcrichton merged commit 81f0b96 into rust-lang:master Mar 8, 2018
@aravind-pg aravind-pg deleted the refactor-select branch March 18, 2018 07:07
@pnkfelix pnkfelix mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aravind-pg @rust-highfive @nikomatsakis @bors @alexcrichton