Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always print aborting due to n previous error(s) #49046

Merged
merged 4 commits into from
Mar 24, 2018
Merged

Always print aborting due to n previous error(s) #49046

merged 4 commits into from
Mar 24, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 15, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2018
@bors
Copy link
Contributor

bors commented Mar 16, 2018

☔ The latest upstream changes (presumably #49051) made this pull request unmergeable. Please resolve the merge conflicts.

@michaelwoerister
Copy link
Member

@estebank, could you take a look at the last commit (b1d872b)? This PR changes diagnostics output and I'd like to make sure that that's OK.

@estebank
Copy link
Contributor

@michaelwoerister LGTM++

@michaelwoerister
Copy link
Member

Looks good to me too! There seems to be some overlap with #49030 though. I'll just approve for now. A merge conflict should be the worst that can happen.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit b1d872b has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
0616e86 
Always print `aborting due to n previous error(s)`

r? @michaelwoerister
@frewsxcv frewsxcv mentioned this pull request Mar 23, 2018
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
a10dd4d 
Always print `aborting due to n previous error(s)`

r? @michaelwoerister
@frewsxcv frewsxcv mentioned this pull request Mar 23, 2018
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
19f8431 
Always print `aborting due to n previous error(s)`

r? @michaelwoerister
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Closed
@bors
Copy link
Contributor

bors commented Mar 24, 2018

⌛ Testing commit b1d872b with merge 5a6820b548e20d6ef17ab367b51e33e659ee4143...

@bors
Copy link
Contributor

bors commented Mar 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2018
@kennytm
Copy link
Member

kennytm commented Mar 24, 2018

@bors retry #43283

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
0acfcb8 
Always print `aborting due to n previous error(s)`
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
9c5f372 
Always print `aborting due to n previous error(s)`

r? @michaelwoerister
@kennytm kennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of #49337 - kennytm:rollup, r=kennytm
f5631d9 
Rollup of 21 pull requests

- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors bors merged commit b1d872b into rust-lang:master Mar 24, 2018
@Zoxc Zoxc deleted the error-summary branch March 24, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @bors @michaelwoerister @estebank @kennytm @rust-highfive