Make resuming generators unsafe instead of the creation of immovable generators #49194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
changed the title
|
Awesome! Thanks @Zoxc. Looks like a few of the tests still need |
withoutboats
added
S-waiting-on-author
Zoxc
force-pushed
the
unsafe-generator
branch
4 times, most recently
from
496c585
to
55d73db
Compare
|
Travis passes now. |
cramertj
reviewed
Mar 20, 2018
| @@ -18,7 +18,7 @@ impl<T: Generator<Return = ()>> Iterator for W<T> { | |||
| type Item = T::Yield; | |||
|
|
|||
| fn next(&mut self) -> Option<Self::Item> { | |||
| match self.0.resume() { | |||
| match unsafe { self.0.resume() } { | |||
There was a problem hiding this comment.
This impl isn't actually sound anymore since the iterator can move-- can you leave a comment? (I think it's fine to leave it because the Pin version will come soon, but there should probably be a note about it)
|
@bors r+ The |
|
📌 Commit 55d73db has been approved by |
bors
added
S-waiting-on-bors
|
📌 Commit 57896ab has been approved by |
Nice :) |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2018
Make resuming generators unsafe instead of the creation of immovable generators cc @withoutboats Fixes rust-lang#47787
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
Make resuming generators unsafe instead of the creation of immovable generators Fixes rust-lang#47787
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
Make resuming generators unsafe instead of the creation of immovable generators cc @withoutboats Fixes rust-lang#47787
bors
added a commit
that referenced
this pull request
Mar 24, 2018
Nemo157
added a commit
to Nemo157/futures-await
that referenced
this pull request
Mar 25, 2018
As of rust-lang/rust#49194 it's now unsafe to resume a generator, but safe to create an immovable generator. Fixes alexcrichton#74
Nemo157
added a commit
to Nemo157/futures-await
that referenced
this pull request
Mar 25, 2018
As of rust-lang/rust#49194 it's now unsafe to resume a generator, but safe to create an immovable generator. Fixes alexcrichton#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @withoutboats
Fixes #47787