Skip to content

Unignore borrowck test #49547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2018
Merged

Unignore borrowck test #49547

merged 1 commit into from
Apr 5, 2018

Conversation

@Phlosioneer
Copy link
Contributor

Unignores a test that has been fixed.

See #44831

@Phlosioneer
Unignore borrowck test
7a63900 
Unignores a test that has been fixed.

See rust-lang#44831
@Phlosioneer
Copy link
Contributor Author

Phlosioneer commented Apr 1, 2018 •
edited
Loading

shoot, pushed that commit to the wrong branch. Fixing it now.

Edit: Fixed.

@Phlosioneer Phlosioneer force-pushed the 44831-borrowck-remove-ignore branch from 9fe8740 to 7a63900 Compare April 1, 2018 04:06
@arielb1
Copy link
Contributor

arielb1 commented Apr 1, 2018

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 1, 2018

📌 Commit 7a63900 has been approved by arielb1

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 1, 2018
@bors
Copy link
Collaborator

bors commented Apr 1, 2018

⌛ Testing commit 7a63900 with merge 54cac10...

bors added a commit that referenced this pull request Apr 1, 2018
@bors
Auto merge of #49547 - Phlosioneer:44831-borrowck-remove-ignore, r=ar…
54cac10 
…ielb1

Unignore borrowck test

Unignores a test that has been fixed.

See #44831
@bors
Copy link
Collaborator

bors commented Apr 1, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2018
@kennytm
Copy link
Member

kennytm commented Apr 4, 2018

@bors retry

Spurious segfault when testing cargo.

test workspaces::workspace_with_transitive_dev_deps ... ok
failures:
---- rustflags::two_matching_in_config stdout ----
	running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe run`
thread 'rustflags::two_matching_in_config' panicked at '
Expected: execs
    but: exited with exit code: 3221225477
--- stdout
--- stderr
   Compiling foo v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t983/foo)
    Finished dev [unoptimized + debuginfo] target(s) in 0.30 secs
     Running `target\debug\foo.exe`
error: process didn't exit successfully: `target\debug\foo.exe` (exit code: 3221225477)
', tools\cargo\tests\testsuite\hamcrest.rs:13:9
failures:
    rustflags::two_matching_in_config
test result: FAILED. 1199 passed; 1 failed; 4 ignored; 0 measured; 0 filtered out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
@kennytm
Rollup merge of rust-lang#49547 - Phlosioneer:44831-borrowck-remove-i…
00ada06 
…gnore, r=arielb1

Unignore borrowck test

Unignores a test that has been fixed.

See rust-lang#44831
@kennytm kennytm mentioned this pull request Apr 4, 2018
Merged
bors added a commit that referenced this pull request Apr 4, 2018
@bors
Auto merge of #49642 - kennytm:rollup, r=kennytm
74abffe 
Rollup of 25 pull requests

Successful merges:

 - #49179 (Handle future deprecation annotations )
 - #49512 (Add support for variant and types fields for intra links)
 - #49515 (fix targetted value background)
 - #49516 (Add missing anchor for union type fields)
 - #49532 (Add test for rustdoc ignore test)
 - #49533 (Add #[must_use] to a few standard library methods)
 - #49540 (Fix miri Discriminant() for non-ADT)
 - #49559 (Introduce Vec::resize_with method (see #41758))
 - #49570 (avoid IdxSets containing garbage above the universe length)
 - #49577 (Stabilize String::replace_range)
 - #49599 (Fix typo)
 - #49603 (Fix url for intra link provided method)
 - #49607 (Stabilize iterator methods in 1.27)
 - #49609 (run-pass/attr-stmt-expr: expand test cases)
 - #49612 (Fix "since" version for getpid feature.)
 - #49618 (Fix build error when compiling libcore for 16bit targets)
 - #49619 (tweak core::fmt docs)
 - #49637 (Stabilize parent_id())
 - #49639 (Update Cargo)
 - #49628 (Re-write the documentation index)
 - #49594 (Add some performance guidance to std::fs and std::io docs)
 - #49625 (miri: add public alloc_kind accessor)
 - #49634 (Add a test for the fix to issue #43058)
 - #49641 (Regression test for #46314)
 - #49547 (Unignore borrowck test)

Failed merges:
@alexcrichton alexcrichton merged commit 7a63900 into rust-lang:master Apr 5, 2018
@Phlosioneer Phlosioneer deleted the 44831-borrowck-remove-ignore branch April 5, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturon aturon

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Phlosioneer @arielb1 @bors @kennytm @alexcrichton @aturon