Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 25 pull requests #49642

Merged
merged 65 commits into from
Apr 5, 2018
Merged

Rollup of 25 pull requests #49642

merged 65 commits into from
Apr 5, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Apr 4, 2018

Successful merges:

Failed merges:

varkor and others added 30 commits March 26, 2018 22:14
This will check for regression on issue rust-lang#32556
Chosen to start a precedent of using it on ones that are potentially-expensive and where using it for side effects is particularly discouraged.

Discuss :)
Unignores a test that has been fixed.

See rust-lang#44831
This makes sure that all bits in each IdxSet between the universe length
and the end of the word are all zero instead of being in an indeterminate state.

This fixes a crash with RUST_LOG=rustc_mir, and is probably a good idea
anyway.
It was stabilized right before the beta branch was cut for 1.26.0.

See rust-lang#49523 (comment)
Remove an outdated claim about passing something or other to a function. Also swap the variable names in the example.
Swap the variable names in the example.
Add some performance guidance to std::fs and std::io docs

Adds more documentation about performance to various "read" functions in `fs` and `io`, and to `BufReader`/`BufWriter`, with the goal of helping developers choose the best option for a given task.
…li-obk

miri: add public alloc_kind accessor
…matsakis

Add a test for the fix to issue rust-lang#43058

Followed the instructions laid out here rust-lang#43058 (comment)
…komatsakis

Regression test for rust-lang#46314

rust-lang#46314 is fixed by NLL. This PR adds a regression test for the bug. Intended for rust-lang#47366.
@bors
Copy link
Contributor

bors commented Apr 4, 2018

☔ The latest upstream changes (presumably #48913) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm kennytm changed the title Rollup of 26 pull requests Rollup of 25 pull requests Apr 4, 2018
@kennytm
Copy link
Member Author

kennytm commented Apr 4, 2018

@bors r+

Removed #49623 (Cargo.lock conflict).

@bors
Copy link
Contributor

bors commented Apr 4, 2018

📌 Commit 86e23dd has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2018
@kennytm kennytm changed the title Rollup of 25 pull requests Rollup of 24 pull requests Apr 4, 2018
@kennytm
Copy link
Member Author

kennytm commented Apr 4, 2018

@bors r+

Removed #48171 (already testing)

@bors
Copy link
Contributor

bors commented Apr 4, 2018

📌 Commit f29d20e has been approved by kennytm

…gnore, r=arielb1

Unignore borrowck test

Unignores a test that has been fixed.

See rust-lang#44831
@kennytm kennytm changed the title Rollup of 24 pull requests Rollup of 25 pull requests Apr 4, 2018
@kennytm
Copy link
Member Author

kennytm commented Apr 4, 2018

@bors r+

Added #49547.

@bors
Copy link
Contributor

bors commented Apr 4, 2018

📌 Commit 00ada06 has been approved by kennytm

@bors
Copy link
Contributor

bors commented Apr 4, 2018

⌛ Testing commit 00ada06 with merge 74abffe...

bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests

Successful merges:

 - #49179 (Handle future deprecation annotations )
 - #49512 (Add support for variant and types fields for intra links)
 - #49515 (fix targetted value background)
 - #49516 (Add missing anchor for union type fields)
 - #49532 (Add test for rustdoc ignore test)
 - #49533 (Add #[must_use] to a few standard library methods)
 - #49540 (Fix miri Discriminant() for non-ADT)
 - #49559 (Introduce Vec::resize_with method (see #41758))
 - #49570 (avoid IdxSets containing garbage above the universe length)
 - #49577 (Stabilize String::replace_range)
 - #49599 (Fix typo)
 - #49603 (Fix url for intra link provided method)
 - #49607 (Stabilize iterator methods in 1.27)
 - #49609 (run-pass/attr-stmt-expr: expand test cases)
 - #49612 (Fix "since" version for getpid feature.)
 - #49618 (Fix build error when compiling libcore for 16bit targets)
 - #49619 (tweak core::fmt docs)
 - #49637 (Stabilize parent_id())
 - #49639 (Update Cargo)
 - #49628 (Re-write the documentation index)
 - #49594 (Add some performance guidance to std::fs and std::io docs)
 - #49625 (miri: add public alloc_kind accessor)
 - #49634 (Add a test for the fix to issue #43058)
 - #49641 (Regression test for #46314)
 - #49547 (Unignore borrowck test)

Failed merges:
@bors
Copy link
Contributor

bors commented Apr 5, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 5, 2018
@TimNN
Copy link
Contributor

TimNN commented Apr 5, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

1 similar comment
@TimNN
Copy link
Contributor

TimNN commented Apr 5, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@alexcrichton
Copy link
Member

All dist builders passed, merging manually

@alexcrichton alexcrichton merged commit 00ada06 into rust-lang:master Apr 5, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.