Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE with main's return type containing lifetimes #49692

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Apr 5, 2018

Fixes #48890

@TimNN
Copy link
Contributor

TimNN commented Apr 5, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Resolving deltas: 100% (611607/611607), completed with 4865 local objects.
---
curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104
The command "curl -fo /home/travis/stamp https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/2017-03-17-stamp-x86_64-unknown-linux-musl" failed. Retrying, 2 of 3.
---
[00:01:57] configure: rust.quiet-tests     := True
---
[00:44:34] ..........................................................................i.........................
[00:44:40] .................i..................................................................................
---
[00:45:17] ..............................................................................................i.....
[00:45:24] ...................................................................i................................
---
[00:46:20] .............................................i......................................................
---
[00:50:24] .............................i......................................................................
[00:50:40] ..............................................................i.....................................
[00:50:56] ...............................................i....................................................
[00:51:17] ....................................................................................................
[00:51:40] ....................................................................................................
[00:52:03] ....................................................................................................
[00:52:28] .i...............................................................................................i..
[00:52:54] ...........................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:53:07] .........................
[00:53:39] ....................................................................................................
[00:54:16] ...............................................................ii...................................
[00:55:01] ..........................i....................................................itest [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:55:10] .ii.................
[00:55:53] .......................................................................................iiiiiii......
---
[00:58:13] ..................i............................................................ii.iii...............
[00:58:21] ....................................................................................................
[00:58:29] ........i..............................i............................................................
[00:58:37] ....................................................................................................
[00:58:44] ....................i...............................................................................
[00:58:52] ....................................................................................................
[00:59:02] ....................................................................................................
[00:59:13] ....................................................................................................
[00:59:24] ....................................................................................................
[00:59:39] ....................................................................................................
[00:59:47] .............i......................................................................................
[00:59:57] ................i..ii...............................................................................
[01:00:07] ....................................................................................................
[01:00:18] ....................................................................................................
[01:00:28] ..................................................................................i.................
[01:00:39] ............................i.......................................................................
---
[01:01:17] ...........................i........................................................................
[01:01:18] ....................................................................i...............................
[01:01:19] ................i.......................................................
---
[01:01:35] .............iF.......................
[01:01:35] failures:
[01:01:35] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:478:22
[01:01:35]
[01:01:35] ---- [run-fail] run-fail/rfc-1937-termination-trait/termination-trait-for-str.rs stdout ----
[01:01:35]
[01:01:35] error: Error: expected failure status (Some(101)) but received status Some(1).
---
[01:01:35] Error: "An error message for you"
[01:01:35]
[01:01:35] ------------------------------------------
[01:01:35]
[01:01:35] thread '[run-fail] run-fail/rfc-1937-termination-trait/termination-trait-for-str.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:2901:9
---
[01:01:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zmiri -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zmiri -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:01:35] expected success, got: exit code: 101
[01:01:35]
[01:01:35]
[01:01:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:01:35] Build completed unsuccessfully in 0:18:19
[01:01:35] Makefile:58: recipe for target 'check' failed
[01:01:35] make: *** [check] Error 1
---
$ dmesg | grep -i kill
[   11.393158] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@nikomatsakis nikomatsakis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 5, 2018
@nikomatsakis
Copy link
Contributor

@sinkuu nice! Looks like you need a // failure-status: 1 comment in the tests.

@arielb1
Copy link
Contributor

arielb1 commented Apr 7, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2018

📌 Commit 40a1ee8 has been approved by arielb1

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 7, 2018
@arielb1
Copy link
Contributor

arielb1 commented Apr 7, 2018

Nice set of tests!

@arielb1
Copy link
Contributor

arielb1 commented Apr 7, 2018

@bors p=1

This is a beta-nominated PR

@bors
Copy link
Contributor

bors commented Apr 7, 2018

⌛ Testing commit 40a1ee8 with merge 8228d8e...

bors added a commit that referenced this pull request Apr 7, 2018
Fix ICE with `main`'s return type containing lifetimes

Fixes #48890
@bors
Copy link
Contributor

bors commented Apr 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing 8228d8e to master...

@bors bors merged commit 40a1ee8 into rust-lang:master Apr 7, 2018
@scottmcm
Copy link
Member

This was beta-nominated; what needs to happen for a beta merge?

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 20, 2018
@alexcrichton
Copy link
Member

@scottmcm this was waiting for beta-accepted which I've now applied, so should be good to go!

(gonna review a few more and then do a lot of backports at once)

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2018
bors added a commit that referenced this pull request Apr 21, 2018
[beta] Processing merged backports

This is a backport of the following PRs:

* #49386
* #49465
* #49647
* #49692
* #49695
* #49714
* #49730
* #49830
* #49981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants