Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for the test crate with the std docs #49465

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Add docs for the test crate with the std docs #49465

merged 1 commit into from
Apr 14, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Mar 29, 2018

If the compiler docs aren't going to include the test crate then it may as well be included with std.

Fixes #49388

@ollie27
Add docs for the test crate with the std docs
e719bb0 
If the compiler docs aren't going to include the test crate then it may as well be included with std.
@ollie27 ollie27 mentioned this pull request Mar 29, 2018
Closed
@Mark-Simulacrum
Copy link
Member

cc @rust-lang/docs, if you want this change I believe it's correct in terms of code.

@QuietMisdreavus
Copy link
Member

We've already been shipping docs for test and proc_macro with the std docs, right? Does this even affect proc_macro at all?

@ollie27
Copy link
Member Author

ollie27 commented Mar 29, 2018

The current list of crates we ship docs for is alloc, core, proc_macro, std and std_unicode as can be seen on https://doc.rust-lang.org/1.25.0/std/. This is just adding test to that list.

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2018
@ollie27
Copy link
Member Author

ollie27 commented Apr 5, 2018

This will need backporting to beta now if this is accepted.

@pietroalbini pietroalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 9, 2018
@pietroalbini
Copy link
Member

@rust-lang/docs, can we get a decision on this PR? Thanks!

@pietroalbini pietroalbini added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2018
@steveklabnik steveklabnik added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 9, 2018
@steveklabnik
Copy link
Member

@rfcbot: merge

I'd like to move that we accept this. People are confused about where to find these docs on IRC fairly often.

@QuietMisdreavus
Copy link
Member

QuietMisdreavus commented Apr 9, 2018 •
edited by frewsxcv
Loading

Manual tickyboxes activate!

@steveklabnik wants to merge this PR. See the post above for explanation.

@frewsxcv
Copy link
Member

unanimous docs team approval! ✅

@bors r=steveklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 14, 2018

📌 Commit e719bb0 has been approved by steveklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Apr 14, 2018
@frewsxcv
Copy link
Member

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge of rust-lang#49465 - ollie27:rustbuild_test_docs, r=stev…
15eb465 
…eklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez

Add docs for the test crate with the std docs

If the compiler docs aren't going to include the test crate then it may as well be included with std.

Fixes rust-lang#49388
@kennytm kennytm mentioned this pull request Apr 14, 2018
Merged
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of #49939 - kennytm:rollup, r=kennytm
21dae95 
Rollup of 14 pull requests

Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864

Failed merges:
@bors bors merged commit e719bb0 into rust-lang:master Apr 14, 2018
@ollie27 ollie27 deleted the rustbuild_test_docs branch April 14, 2018 17:28
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 20, 2018
@alexcrichton alexcrichton mentioned this pull request Apr 20, 2018
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2018
bors added a commit that referenced this pull request Apr 21, 2018
@bors
Auto merge of #50127 - alexcrichton:beta-next2, r=alexcrichton
9b97d1e 
[beta] Processing merged backports

This is a backport of the following PRs:

* #49386
* #49465
* #49647
* #49692
* #49695
* #49714
* #49730
* #49830
* #49981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ollie27 @Mark-Simulacrum @QuietMisdreavus @pietroalbini @steveklabnik @frewsxcv @bors @alexcrichton @shepmaster @aturon