Cross-compile builder to Windows for PRs on Travis #49866

Mark-Simulacrum · 2018-04-11T03:10:26Z

I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast).

r? @alexcrichton

rust-highfive · 2018-04-11T03:10:36Z

Warning

These commits modify submodules.

Mark-Simulacrum · 2018-04-11T03:11:01Z

Oh, and I should cc @aidanhs and probably @kennytm

TimNN · 2018-04-11T03:13:15Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:07] error: Server does not allow request for unadvertised object e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f
[00:00:07] Fetched in submodule path 'src/libcompiler_builtins', but it did not contain e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f. Direct fetching of that commit failed.
---
[00:00:08] error: Server does not allow request for unadvertised object e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f
[00:00:08] Fetched in submodule path 'src/libcompiler_builtins', but it did not contain e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f. Direct fetching of that commit failed.
---
[00:00:09] error: Server does not allow request for unadvertised object e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f
[00:00:09] Fetched in submodule path 'src/libcompiler_builtins', but it did not contain e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f. Direct fetching of that commit failed.
---
[00:00:10] error: Server does not allow request for unadvertised object e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f
[00:00:10] Fetched in submodule path 'src/libcompiler_builtins', but it did not contain e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f. Direct fetching of that commit failed.
---
[00:00:11] error: Server does not allow request for unadvertised object e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f
[00:00:11] Fetched in submodule path 'src/libcompiler_builtins', but it did not contain e0bb71ae93695d01cbeaf5dd7a43f0a7b40fb32f. Direct fetching of that commit failed.
[00:00:11] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:0fce8196:start=1523416322650234846,finish=1523416322656769057,duration=6534211
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:2b17b0e2
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:2b17b0e2:start=1523416322663415776,finish=1523416322669924092,duration=6508316
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:059b9345
$ dmesg | grep -i kill
[   10.607272] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton

Nice!

Looking at Travis it looks like this took ~6m, although I don't think it's checking librustc yet. I wonder if to solve the miniz-sys issue we could create a shim shell script C compiler which basically does nothing? Or otherwise provide overrides for the relevant build scripts?

Additionally, would it be possible to skip the submodule updates in this PR? I think most of them shouldn't be necessary other than maybe libcompiler_builtins, right?

alexcrichton · 2018-04-11T14:20:04Z

src/libstd/build.rs

@@ -17,6 +17,10 @@ use std::process::Command;
 use build_helper::{run, native_lib_boilerplate};

 fn main() {
+    if *"1" == *env::var_os("CHECK").unwrap_or_default() {


Could this be called RUSTBUILD_CHECK and that way I think we could skip the == *"1" and instead just check for its presence

Mark-Simulacrum · 2018-04-11T14:25:14Z

We need submodule updates for at least src/tools/cargo and src/tools/rls I think (and maybe others) since Cargo needs those to resolve the Cargo.lock/Cargo.toml configuration IIRC.

alexcrichton · 2018-04-11T15:36:41Z

Ah good point yeah, it may be that the submodules are too entangled to remove them from being updated

Mark-Simulacrum · 2018-04-11T16:19:15Z

Note: Making all build scripts no-ops doesn't work as winapi (at least) needs it's build script to run in order to compile (or so I assume). That means we'll probably need a whitelist -- how do you feel about that, @alexcrichton? Is a whitelist fine? I'm not really happy with that solution/answer...

alexcrichton · 2018-04-11T16:40:13Z

Hm ok we probably don't want to bend over backwards too much as this may run the risk of causing more bugs than it discovers, so maybe we could use a docker image with a MinGW toolchain and go from there?

The main thing we want to skip is LLVM mostly

TimNN · 2018-04-11T17:26:27Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:00c61524:start=1523462589305727837,finish=1523462589311236929,duration=5509092
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:013423bb
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:013423bb:start=1523462589316487295,finish=1523462589321653722,duration=5166427
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:062f7100
$ dmesg | grep -i kill
[   11.259908] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

TimNN · 2018-04-11T18:15:54Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:111f63b0:start=1523463323129364932,finish=1523463323139017390,duration=9652458
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:33269af8
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:33269af8:start=1523463323147430575,finish=1523463323156014950,duration=8584375
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:3370a7f0
$ dmesg | grep -i kill
[   11.520591] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-04-12T03:08:32Z

@alexcrichton Okay, so I've gone with the docker approach now and it compiles std, test, and rustc. I think this is pretty much ready to land from my perspective pending any concerns from you; there are effectively no rustbuild changes to speak of: just making rustc get built on check for --target (not --host) builds.

alexcrichton

This looks great! Just a few minor nits

alexcrichton · 2018-04-12T15:25:31Z

.travis.yml

@@ -176,6 +176,8 @@ matrix:
      if: branch = auto
    - env: IMAGE=x86_64-gnu-distcheck
      if: branch = auto
+    - env: IMAGE=mingw-check
+      if: type = pull_request


I'd actually run this on the auto branch as well just to be extra sure it's always passing

alexcrichton · 2018-04-12T15:26:28Z

src/ci/docker/mingw-check/Dockerfile

+COPY scripts/sccache.sh /scripts/
+RUN sh /scripts/sccache.sh
+
+ENV SCRIPT python2.7 ../x.py check --target=i686-pc-windows-gnu -vv


The -vv here can probably be removed

alexcrichton · 2018-04-12T15:28:15Z

src/bootstrap/check.rs

@@ -64,7 +64,6 @@ pub struct Rustc {

 impl Step for Rustc {
    type Output = ();
-    const ONLY_HOSTS: bool = true;


Instead of removing this, would --host=i686-pc-windows-gnu work below?

Mark-Simulacrum · 2018-04-12T17:41:43Z

Nits fixed.

alexcrichton · 2018-04-12T18:05:23Z

@bors: r+

bors · 2018-04-12T18:05:24Z

📌 Commit de34533 has been approved by alexcrichton

@alexcrichton

…r=alexcrichton Cross-compile builder to Windows for PRs on Travis I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast). r? @alexcrichton

…r=alexcrichton Cross-compile builder to Windows for PRs on Travis I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast).

Rollup of 14 pull requests Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864 Failed merges:

rust-highfive assigned alexcrichton Apr 11, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2018

alexcrichton reviewed Apr 11, 2018

View reviewed changes

Mark-Simulacrum force-pushed the pr-travis-windows branch 2 times, most recently from 45e747c to fe63344 Compare April 11, 2018 16:07

Mark-Simulacrum force-pushed the pr-travis-windows branch from fe63344 to a9c4618 Compare April 12, 2018 00:25

alexcrichton reviewed Apr 12, 2018

View reviewed changes

Add check builder for Windows to Travis

de34533

Mark-Simulacrum force-pushed the pr-travis-windows branch from a9c4618 to de34533 Compare April 12, 2018 17:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2018

kennytm mentioned this pull request Apr 13, 2018

Rollup of 11 pull requests #49924

Closed

kennytm mentioned this pull request Apr 13, 2018

Rollup of 14 pull requests #49939

Merged

bors merged commit de34533 into rust-lang:master Apr 14, 2018

Mark-Simulacrum deleted the pr-travis-windows branch June 8, 2019 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cross-compile builder to Windows for PRs on Travis #49866

Cross-compile builder to Windows for PRs on Travis #49866

Mark-Simulacrum commented Apr 11, 2018 •

edited

Loading

rust-highfive commented Apr 11, 2018

Mark-Simulacrum commented Apr 11, 2018

TimNN commented Apr 11, 2018

alexcrichton left a comment

alexcrichton Apr 11, 2018

Mark-Simulacrum commented Apr 11, 2018

alexcrichton commented Apr 11, 2018

Mark-Simulacrum commented Apr 11, 2018

alexcrichton commented Apr 11, 2018

TimNN commented Apr 11, 2018

TimNN commented Apr 11, 2018

Mark-Simulacrum commented Apr 12, 2018

alexcrichton left a comment

alexcrichton Apr 12, 2018

alexcrichton Apr 12, 2018

alexcrichton Apr 12, 2018

Mark-Simulacrum commented Apr 12, 2018

alexcrichton commented Apr 12, 2018

bors commented Apr 12, 2018

Cross-compile builder to Windows for PRs on Travis #49866

Cross-compile builder to Windows for PRs on Travis #49866

Conversation

Mark-Simulacrum commented Apr 11, 2018 • edited Loading

rust-highfive commented Apr 11, 2018

Mark-Simulacrum commented Apr 11, 2018

TimNN commented Apr 11, 2018

alexcrichton left a comment

Choose a reason for hiding this comment

alexcrichton Apr 11, 2018

Choose a reason for hiding this comment

Mark-Simulacrum commented Apr 11, 2018

alexcrichton commented Apr 11, 2018

Mark-Simulacrum commented Apr 11, 2018

alexcrichton commented Apr 11, 2018

TimNN commented Apr 11, 2018

TimNN commented Apr 11, 2018

Mark-Simulacrum commented Apr 12, 2018

alexcrichton left a comment

Choose a reason for hiding this comment

alexcrichton Apr 12, 2018

Choose a reason for hiding this comment

alexcrichton Apr 12, 2018

Choose a reason for hiding this comment

alexcrichton Apr 12, 2018

Choose a reason for hiding this comment

Mark-Simulacrum commented Apr 12, 2018

alexcrichton commented Apr 12, 2018

bors commented Apr 12, 2018

Mark-Simulacrum commented Apr 11, 2018 •

edited

Loading