Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Atomic*::fetch_update docs #49916

Merged
merged 1 commit into from
Apr 14, 2018
Merged

improve Atomic*::fetch_update docs #49916

merged 1 commit into from
Apr 14, 2018

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Apr 12, 2018

This clarifies that fetch_update always returns the previous value, either as Ok(_) or Err(_), depending on whether the supplied update function returned Some(_) or None.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2018
@kennytm
Copy link
Member

kennytm commented Apr 13, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2018

📌 Commit 2f60341 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2018
@kennytm kennytm mentioned this pull request Apr 13, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Apr 13, 2018
@kennytm
Rollup merge of rust-lang#49916 - llogiq:doc-atomic-fetch-update, r=k…
ba8be1d 
…ennytm

improve Atomic*::fetch_update docs

This clarifies that fetch_update *always* returns the previous value, either as `Ok(_)` or `Err(_)`, depending on whether the supplied update function returned `Some(_)` or `None`.
@kennytm kennytm mentioned this pull request Apr 13, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge of rust-lang#49916 - llogiq:doc-atomic-fetch-update, r=k…
31906e4 
…ennytm

improve Atomic*::fetch_update docs

This clarifies that fetch_update *always* returns the previous value, either as `Ok(_)` or `Err(_)`, depending on whether the supplied update function returned `Some(_)` or `None`.
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of #49939 - kennytm:rollup, r=kennytm
21dae95 
Rollup of 14 pull requests

Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864

Failed merges:
@bors bors merged commit 2f60341 into rust-lang:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llogiq @rust-highfive @kennytm @bors