Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize num::NonZeroU* #50808

Merged
merged 3 commits into from
May 17, 2018
Merged

Stabilize num::NonZeroU* #50808

merged 3 commits into from
May 17, 2018

Conversation

SimonSapin
Copy link
Contributor

Tracking issue: #49137

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2018
@SimonSapin SimonSapin mentioned this pull request May 16, 2018
Closed
7 tasks
@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels May 16, 2018
@alexcrichton
Copy link
Member

@bors: r+

🎉

@bors
Copy link
Contributor

bors commented May 16, 2018

📌 Commit f7197fb has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2018
kennytm
kennytm reviewed May 16, 2018
View reviewed changes
src/test/rustdoc/synthetic_auto/no-redundancy.rs Outdated
@@ -20,7 +20,7 @@ where

// @has no_redundancy/struct.Outer.html
// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<T> Send for \
// Outer<T> where T: Copy + Send"
// Outer<T> where T: Send + Copy"
Copy link
Member

@kennytm kennytm May 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is strange. cc @GuillaumeGomez @QuietMisdreavus @Phlosioneer (#49196)

I thought #49123 has been fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is a rebase of an old branch, this change is probably not necessary anymore. Removed.

SimonSapin added 3 commits May 16, 2018 19:08
@SimonSapin
Make core::nonzero private
ee85bfd 
It is now an implementation detail of ptr::NonNull and num::NonZero*
@SimonSapin
Remove unstable deprecated num::NonZeroI* types
c536639
@SimonSapin
Stabilize num::NonZeroU*
89d9ca9 
Tracking issue: rust-lang#49137
@kennytm
Copy link
Member

kennytm commented May 16, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented May 16, 2018

📌 Commit 89d9ca9 has been approved by alexcrichton

@kennytm kennytm mentioned this pull request May 16, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request May 16, 2018
@kennytm
Rollup merge of rust-lang#50808 - SimonSapin:nonzero, r=alexcrichton
02aedec 
Stabilize num::NonZeroU*

Tracking issue: rust-lang#49137
bors added a commit that referenced this pull request May 17, 2018
@bors
Auto merge of #50807 - kennytm:rollup, r=kennytm
b559710 
Rollup of 17 pull requests

Successful merges:

 - #50170 (Implement From for more types on Cow)
 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50808 (Stabilize num::NonZeroU*)
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:
@bors bors merged commit 89d9ca9 into rust-lang:master May 17, 2018
@SimonSapin SimonSapin deleted the nonzero branch May 18, 2018 18:25
This was referenced May 19, 2018
Merged
Open
Closed
@RalfJung RalfJung mentioned this pull request Apr 16, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 20, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84251 - RalfJung:non-zero-const-since, r=ke…
4e18900 
…nnytm

fix 'const-stable since' for NonZeroU*::new_unchecked

For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that.

I think this `since` is also incorrect:
```rust
            #[stable(feature = "from_nonzero", since = "1.31.0")]
            impl From<$Ty> for $Int {
```
The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 21, 2021
@Dylan-DPC
Rollup merge of rust-lang#84251 - RalfJung:non-zero-const-since, r=ke…
fab8b25 
…nnytm

fix 'const-stable since' for NonZeroU*::new_unchecked

For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that.

I think this `since` is also incorrect:
```rust
            #[stable(feature = "from_nonzero", since = "1.31.0")]
            impl From<$Ty> for $Int {
```
The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 21, 2021
@m-ou-se
Rollup merge of rust-lang#84251 - RalfJung:non-zero-const-since, r=ke…
f013c07 
…nnytm

fix 'const-stable since' for NonZeroU*::new_unchecked

For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that.

I think this `since` is also incorrect:
```rust
            #[stable(feature = "from_nonzero", since = "1.31.0")]
            impl From<$Ty> for $Int {
```
The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 21, 2021
@m-ou-se
Rollup merge of rust-lang#84251 - RalfJung:non-zero-const-since, r=ke…
47886ea 
…nnytm

fix 'const-stable since' for NonZeroU*::new_unchecked

For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that.

I think this `since` is also incorrect:
```rust
            #[stable(feature = "from_nonzero", since = "1.31.0")]
            impl From<$Ty> for $Int {
```
The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees

@KodrAus KodrAus

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimonSapin @rust-highfive @alexcrichton @bors @kennytm @KodrAus