Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize impls for NonZero* #1274

Closed
dtolnay opened this issue May 21, 2018 · 0 comments
Closed

Stabilize impls for NonZero* #1274

dtolnay opened this issue May 21, 2018 · 0 comments
Labels
enhancement

Comments

@dtolnay
Copy link
Member

dtolnay commented May 21, 2018

These types were stabilized in rust-lang/rust#50808 and will be released in Rust 1.28.

We should use version detection through the Serde build.rs script to automatically provide the impl on sufficiently new compilers.
SimonSapin added a commit to SimonSapin/serde that referenced this issue May 24, 2018
@SimonSapin
Implement for std::num::NonZero* on Rust 1.28+
c29be4d 
… regardless of the `unstable` feature. Fix serde-rs#1274.
@SimonSapin SimonSapin mentioned this issue May 24, 2018
Merged
SimonSapin added a commit to SimonSapin/serde that referenced this issue May 24, 2018
@SimonSapin
Implement for std::num::NonZero* on Rust 1.28+
defd885 
… regardless of the `unstable` feature. Fix serde-rs#1274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtolnay