Fix run button style #51297
Merged
Fix run button style #51297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Can you provide a screenshot? I don't know what this is going to touch, offhand. |
|
I put it back to current (stable/beta) style. Try to hover on the current nightly docs. |
|
For posterity: Light theme, current nightly:
Light theme, current stable:
Dark theme, current nightly:
Dark theme, current stable:
Someone looking back at this PR in the future won't be able to see what this change affected. I'm not super comfortable with CSS, and i don't have a perfect understanding of our page layout, so when i see a PR like this i really want to see what it's intended to change. Since i know you run a Mac, you can use Shift-Command-4 to take a screenshot of just an area of the screen. @bors r+ rollup |
|
📌 Commit 7585632 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 3, 2018
…=QuietMisdreavus Fix run button style r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Jun 3, 2018
Rollup of 6 pull requests Successful merges: - #51143 (Specify that packed types must derive, not implement, Copy) - #51226 (Make Layout's align a NonZeroUsize) - #51297 (Fix run button style) - #51306 (impl Default for &mut str) - #51312 (Clarify the difference between get_mut and into_mut for OccupiedEntry) - #51313 (use type name in E0599 enum variant suggestion) Failed merges:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @QuietMisdreavus