Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use type name in E0599 enum variant suggestion #51313

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jun 2, 2018

Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.

Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jun 3, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2018

📌 Commit 9eb70c3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 3, 2018
… r=oli-obk

use type name in E0599 enum variant suggestion

Also, rename the variable from "type_str" to "item_kind" to avoid
the ambiguity that caused this bug.
bors added a commit that referenced this pull request Jun 3, 2018
Rollup of 6 pull requests

Successful merges:

 - #51143 (Specify that packed types must derive, not implement, Copy)
 - #51226 (Make Layout's align a NonZeroUsize)
 - #51297 (Fix run button style)
 - #51306 (impl Default for &mut str)
 - #51312 (Clarify the difference between get_mut and into_mut for OccupiedEntry)
 - #51313 (use type name in E0599 enum variant suggestion)

Failed merges:
@bors bors merged commit 9eb70c3 into rust-lang:master Jun 3, 2018
@euclio euclio deleted the variant-name-suggestion-fix branch June 3, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants