Update the compiler-builtins submodule #52499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the compiler-builtins submodule, primarily pulling in rust-lang/compiler-builtins#248 which should resolve a number of undefined symbols on the wasm target by default (instead of leaving them in the final binary).
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8fb918b has been approved by |
bors
added
S-waiting-on-bors
|
How about #52431, should that be closed? |
|
Aha excellent point, I've moved this over to #52431 by updating the submodule a bit further there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the compiler-builtins submodule, primarily pulling in
rust-lang/compiler-builtins#248 which should resolve a number of
undefined symbols on the wasm target by default (instead of leaving them in the
final binary).