Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #52562

Merged
merged 4 commits into from
Jul 21, 2018
Merged

Update clippy #52562

merged 4 commits into from
Jul 21, 2018

Conversation

Manishearth
Copy link
Member

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
###################################                                       49.5%
######################################################################## 100.0%
[00:01:25] extracting /checkout/obj/build/cache/2018-07-13/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:25]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:48] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:48] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:48] make: *** [prepare] Error 1
[00:01:48] Makefile:81: recipe for target 'prepare' failed
[00:01:49] Command failed. Attempt 2/5:
[00:01:49]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:49]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:49] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:49] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:49] make: *** [prepare] Error 1
[00:01:49] Makefile:81: recipe for target 'prepare' failed
[00:01:51] Command failed. Attempt 3/5:
[00:01:51]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:51]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:52] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:52] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:52] Makefile:81: recipe for target 'prepare' failed
[00:01:52] make: *** [prepare] Error 1
[00:01:55] Command failed. Attempt 4/5:
[00:01:55]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:55]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:56] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:56] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:56] Makefile:81: recipe for target 'prepare' failed
[00:01:56] make: *** [prepare] Error 1
[00:02:00] Command failed. Attempt 5/5:
[00:02:00]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:00]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:00] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:00] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:00] make: *** [prepare] Error 1
[00:02:00] Makefile:81: recipe for target 'prepare' failed
[00:02:00] The command has failed after 5 attempts.
travis_time:end:057d05f3:start=1532073589498275237,finish=1532073716333599863,duration=126835324626
---
travis_time:end:0374be99:start=1532073716721943213,finish=1532073716734478164,duration=12534951
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:031bca2b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09441980
travis_time:start:09441980
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1621fe06
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jul 20, 2018

@bors r+ p=14

@bors
Copy link
Contributor

bors commented Jul 20, 2018

📌 Commit 826bec3 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 20, 2018
@pietroalbini
Rollup merge of rust-lang#52562 - Manishearth:clippyup, r=kennytm
5407f1c 
Update clippy

r? @kennytm @oli-obk
@pietroalbini pietroalbini mentioned this pull request Jul 20, 2018
Closed
@bors
Copy link
Contributor

bors commented Jul 20, 2018

⌛ Testing commit 826bec3 with merge 77a6ee663a72063a5b16210c1e1698cbb98a9f87...

@bors
Copy link
Contributor

bors commented Jul 20, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2018
@Manishearth
Copy link
Member Author

I suspect the macro checks PR broke this

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2018
@RalfJung
Copy link
Member

Any chance of getting this in today so that we can get a new nightly again? :D

RalfJung
RalfJung reviewed Jul 21, 2018
View reviewed changes
src/librustc/lint/builtin.rs Outdated
@@ -216,7 +217,8 @@ declare_lint! {
declare_lint! {
pub DEPRECATED,
Warn,
"detects use of deprecated items"
"detects use of deprecated items",
report_in_external_macro
Copy link
Member

@RalfJung RalfJung Jul 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read the macro definition to understand that "report_in_external_macro" is essentially a keyword here, and not an identifier. Is there a nicer way to do this? Maybe report_in_external_macro : true?

@oli-obk oli-obk mentioned this pull request Jul 21, 2018
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2018

@bors r=RalfJung p=1

@bors
Copy link
Contributor

bors commented Jul 21, 2018

📌 Commit 2f7edcc has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2018
@bors
Copy link
Contributor

bors commented Jul 21, 2018

⌛ Testing commit 2f7edcc with merge 606713f...

bors added a commit that referenced this pull request Jul 21, 2018
@bors
Auto merge of #52562 - Manishearth:clippyup, r=RalfJung
606713f 
Update clippy

r? @kennytm @oli-obk
@Manishearth
Copy link
Member Author

I don't really see a problem with that, macros invent local keywords all the time. Warn is like that too.

@bors
Copy link
Contributor

bors commented Jul 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing 606713f to master...

@bors bors merged commit 2f7edcc into rust-lang:master Jul 21, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #52562!

Tested on commit 606713f.
Direct link to PR: #52562

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 21, 2018
@rust-highfive
📣 Toolstate changed by rust-lang/rust#52562!
340f4a9 
Tested on commit rust-lang/rust@606713f.
Direct link to PR: <rust-lang/rust#52562>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Manishearth @rust-highfive @kennytm @bors @RalfJung @oli-obk