Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macro check for lint #53559

Merged
merged 4 commits into from
Aug 24, 2018
Merged

Conversation

Dylan-DPC-zz
Copy link

@Dylan-DPC-zz Dylan-DPC-zz commented Aug 21, 2018

Fixes #53537

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2018
@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2018
@kennytm
Copy link
Member

kennytm commented Aug 21, 2018

Could you add a test case?

(cc @durka)

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2018
@Dylan-DPC-zz
Copy link
Author

@kennytm 👍 yah adding a testcase to it now

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:45:38] ....................................................................................................
[00:45:41] ....................................................................................................
[00:45:44] ....................................................................................................
[00:45:46] ....................................................................................................
[00:45:50] ...........................................................................F........................
[00:45:56] ...........................................................................................i.i..ii..
[00:45:59] ....................................................................................................
[00:46:02] .......................................................................................i............
[00:46:05] ....................................................................................................
---
[00:46:26] ...................................................i................................................
[00:46:29] ....................................................................................................
[00:46:31] ....................................................................................................
[00:46:34] ..............................................................................................i.....
 command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lints-in-foreign-macros.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lints-in-foreign-macros/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lints-in-foreign-macros/auxiliary" "-A" "unused"
[00:46:35] ------------------------------------------
[00:46:35] 
[00:46:35] ------------------------------------------
[00:46:35] stderr:
[00:46:35] stderr:
[00:46:35] ------------------------------------------
[00:46:35] {"message":"unused import: `std::string::ToString`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/lint/lints-in-foreign-macros.rs","byte_start":659,"byte_end":680,"line_start":21,"line_end":21,"column_start":16,"column_end":37,"is_primary":true,"text":[{"text":"    () => {use std::string::ToString;} //~ WARN: unused import","highlight_start":16,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/lint/lints-in-foreign-macros.rs","byte_start":718,"byte_end":725,"line_start":24,"line_end":24,"column_start":9,"column_end":16,"is_primary":false,"text":[{"text":"mod a { foo!(); }","highlight_start":9,"highlight_end":16}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"foo!","def_site_span":{"file_name":"/checkout/src/test/ui/lint/lints-in-foreign-macros.rs","byte_start":625,"byte_end":708,"line_start":20,"line_end":22,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"macro_rules! foo {","highlight_start":1,"highlight_end":19},{"text":"    () => {use std::string::ToString;} //~ WARN: unused import","highlight_start":1,"highlight_end":63},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/lints-in-foreign-macros.rs","byte_start":532,"byte_end":546,"line_start":14,"line_end":14,"column_start":9,"column_end":23,"is_primary":true,"text":[{"text":"#![warn(unused_imports)]","highlight_start":9,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: unused import: `std::string::ToString`\n  --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:21:16\n   |\nLL |     () => {use std::string::ToString;} //~ WARN: unused import\n   |                ^^^^^^^^^^^^^^^^^^^^^\n...\nLL | mod a { foo!(); }\n   |         ------- in this macro invocation\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/lints-in-foreign-macros.rs:14:9\n   |\nLL | #![warn(unused_imports)]\n   |         ^^^^^^^^^^^^^^\n\n"}
[00:46:35] {"message":"unused import: `std::string::ToString`","code":{"code":"unused_imports","explanation":nul"spans":[{"file_name":"/checkout/src/test/ui/lint/lints-in-foreign-macros.rs","byte_start":524,"byte_end":984,"line_start":14,"line_end":30,"column_start":1,"column_end":13,"is_primary":true,"text":[{"text":"#![warn(unused_imports)]","highlight_start":1,"highlight_end":25},{"text":"#![warn(missing_docs)]","highlight_start":1,"highlight_end":23},{"text":"","highlight_start":1,"highlight_end":1},{"text":"#[macro_use]","highlight_start":1,"highlight_end":13},{"text":"extern crate lints_in_foreign_macros;","highlight_start":1,"highlight_end":38},{"text":"","highlight_start":1,"highlight_end":1},{"text":"macro_rules! foo {","highlight_start":1,"highlight_end":19},{"text":"    () => {use std::string::ToString;} //~ WARN: unused import","highlight_start":1,"highlight_end":63},{"text":"}","highlight_start":1,"highlight_end":2},{"text":"","highlight_start":1,"highlight_end":1},{"text":"mod a { foo!(); }","highlight_start":1,"highlight_end":18},{"text":"mod b { bar!(); }","highlight_start":1,"highlight_end":18},{"text":"mod c { baz!(use std::string::ToString;); } //~ WARN: unused import","highlight_start":1,"highlight_end":68},{"text":"mod d { baz2!(use std::string::ToString;); } //~ WARN: unused import","highlight_start":1,"highlight_end":69},{"text":"mod e { baz!(pub fn undocumented() {}); }//~ WARN: missing documentation for a function","highlight_start":1,"highlight_end":88},{"text":"","highlight_start":1,"highlight_end":1},{"text":"fn main() {}","highlight_start":1,"highlight_end":13}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","codekout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:46:35] 
[00:46:35] 
[00:46:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:35] Build completed unsuccessfully in 0:03:00
[00:46:35] Build completed unsuccessfully in 0:03:00
[00:46:35] make: *** [check] Error 1
[00:46:35] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:004511c7
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0057742e:start=1534973247611677186,finish=1534973247622287879,duration=10610693
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:25fe3c00
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2df3483f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@durka
Copy link
Contributor

durka commented Aug 23, 2018

Test case LGTM if travis agrees

@kennytm
Copy link
Member

kennytm commented Aug 24, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2018

📌 Commit 747722e has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2018
@bors
Copy link
Contributor

bors commented Aug 24, 2018

⌛ Testing commit 747722e with merge b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60...

@bors
Copy link
Contributor

bors commented Aug 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2018
@rust-highfive
Copy link
Collaborator

The job dist-armhf-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Preparing deploy
travis_fold:end:dpl.2
travis_fold:start:dpl.3
Deploying application
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-analysis-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/llvm-tools-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-std-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-src-nightly.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rustc-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rustc-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rustfmt-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-std-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-src-nightly.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/cargo-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rust-analysis-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/rustfmt-nightly-arm-unknown-linux-gnueabihf.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/cargo-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "b6884ac50ec71ffc9fa72fb91b9c383c1d0d0d60/llvm-tools-nightly-arm-unknown-linux-gnueabihf.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
/home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `initialize': execution expired (Seahorse::Client::NetworkingError)
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `open'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `block in connect'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/timeout.rb:88:in `block in timeout'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/timeout.rb:98:in `call'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/timeout.rb:98:in `timeout'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:878:in `connect'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:1457:in `begin_transport'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/patches.rb:25:in `new_transport_request'
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:1384:in `request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/connection_pool.rb:330:in `request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/handler.rb:72:in `block in transmit'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/handler.rb:121:in `block in session'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/connection_pool.rb:96:in `session_for'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/handler.rb:119:in `session'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/handler.rb:71:in `transmit'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/net_http/handler.rb:45:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/plugins/content_length.rb:12:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_request_signer.rb:88:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_request_signer.rb:23:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_host_id.rb:14:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/xml/error_handler.rb:8:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/helpful_socket_errors.rb:10:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_request_signer.rb:65:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_redirects.rb:15:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:89:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:120:in `retry_request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:103:in `retry_if_possible'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:91:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:120:in `retry_request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:103:in `retry_if_possible'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:91:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:120:in `retry_request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:103:in `retry_if_possible'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/retry_errors.rb:91:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_dualstack.rb:32:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_accelerate.rb:49:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_md5s.rb:31:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_expect_100_continue.rb:21:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_bucket_name_restrictions.rb:12:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_bucket_dns.rb:31:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/rest/handler.rb:7:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/user_agent.rb:12:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/plugins/endpoint.rb:41:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/param_validator.rb:21:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/plugins/raise_response_errors.rb:14:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_sse_cpk.rb:19:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_dualstack.rb:24:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/s3_accelerate.rb:34:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/idempotency_token.rb:18:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/aws-sdk-core/plugins/param_converter.rb:20:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/plugins/response_target.rb:21:in `call'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/request.rb:70:in `send_request'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-core-2.11.115/lib/seahorse/client/base.rb:207:in `block (2 levels) in define_operation_methods'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.115/lib/aws-sdk-resources/services/s3/file_uploader.rb:42:in `block in put_object'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.115/lib/aws-sdk-resources/services/s3/file_uploader.rb:49:in `open_file'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.115/lib/aws-sdk-resources/services/s3/file_uploader.rb:41:in `put_object'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.115/lib/aws-sdk-resources/services/s3/file_uploader.rb:34:in `upload'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/aws-sdk-resources-2.11.115/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.10.0/lib/dpl/provider/s3.rb:99:in `block (2 levels) in upload_multithreaded'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Aug 24, 2018

@bors retry rollup #40474

/home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `initialize': execution expired (Seahorse::Client::NetworkingError)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 24, 2018
bors added a commit that referenced this pull request Aug 24, 2018
Rollup of 16 pull requests

Successful merges:

 - #53311 (Window Mutex: Document that we properly initialize the SRWLock)
 - #53503 (Discourage overuse of mem::forget)
 - #53545 (Fix #50865: ICE on impl-trait returning functions reaching private items)
 - #53559 (add macro check for lint)
 - #53562 (Lament the invincibility of the Turbofish)
 - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into())
 - #53592 (docs: minor stylistic changes to str/string docs)
 - #53594 (Update RELEASES.md to include clippy-preview)
 - #53600 (Fix a grammatical mistake in "expected generic arguments" errors)
 - #53614 (update nomicon and book)
 - #53617 (tidy: Stop requiring a license header)
 - #53618 (Add missing fmt examples)
 - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.)
 - #53644 (Use SmallVec for SmallCStr)
 - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs)
 - #53666 (Added rustc_codegen_llvm to compiler documentation.)
@bors bors merged commit 747722e into rust-lang:master Aug 24, 2018
@Dylan-DPC-zz Dylan-DPC-zz deleted the fix/missing-doc-lint branch August 24, 2018 19:29
@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 25, 2018
@nikomatsakis
Copy link
Contributor

Accepting for beta backport. Trivial fix to regression.

cc @rust-lang/compiler

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 25, 2018
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2018
bors added a commit that referenced this pull request Aug 25, 2018
[beta] Rollup backports

Merged and approved:

* #53559: add macro check for lint
* #53509: resolve: Reject some inaccessible candidates sooner during import resolution
* #53239: rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.
* #53235: Feature gate where clauses on associated type impls
* #53516: resolve: Continue search in outer scopes after applying derive resolution fallback

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants