Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Rollup backports #53700

Merged
merged 8 commits into from
Aug 25, 2018
Merged

[beta] Rollup backports #53700

merged 8 commits into from
Aug 25, 2018

Conversation

pietroalbini
Copy link
Member

Merged and approved:

r? @ghost

Dylan-DPC and others added 8 commits August 25, 2018 15:29
…olution

This allows import resolution to progress in cases like rust-lang#53140
This hack was removed in rust-lang#50949, but without it I found that building
`std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment`
errors, then die `LLVM ERROR: Failed to strip malformed debug info`.

It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack
just for older LLVM.

This reverts commit da579ef.
Fixes rust-lang#53204.
r? @eddyb
@pietroalbini
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Aug 25, 2018

📌 Commit ef2b1f1 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2018
@bors
Copy link
Contributor

bors commented Aug 25, 2018

⌛ Testing commit ef2b1f1 with merge 5c5be09...

bors added a commit that referenced this pull request Aug 25, 2018
[beta] Rollup backports

Merged and approved:

* #53559: add macro check for lint
* #53509: resolve: Reject some inaccessible candidates sooner during import resolution
* #53239: rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.
* #53235: Feature gate where clauses on associated type impls
* #53516: resolve: Continue search in outer scopes after applying derive resolution fallback

r? @ghost
@bors
Copy link
Contributor

bors commented Aug 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing 5c5be09 to beta...

@bors bors merged commit ef2b1f1 into rust-lang:beta Aug 25, 2018
@pietroalbini pietroalbini deleted the beta-backports branch August 25, 2018 17:40
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants