rt: don't save and restore xmm/regs in __morestack. #5418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I'm still not sure why they were being clobbered in the meantime. Maybe there was an SSE-using memmove somewhere unaccounted for, or we failed to preserve them across task switches or something? |
|
I'm wary of landing this before 0.6 since I don't think anything notable has changed on the __morestack path to make this problem go away and hitting it depends on exactly where the end of the stack segment is and possibly whether there is already a cached segment. |
|
OK, let's merge this and see what happens! |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Downgrade unreadable_literal to pedantic As motivated by rust-lang#5418. This is the top most commonly suppressed Clippy style lint, which indicates that the community has decided they don't share Clippy's opinion on the best style of this. I've left the lint in as pedantic, though it could be that "restriction" would be better -- I can see this lint being useful as an opt-in restriction in some codebases. changelog: Remove unreadable_literal from default set of enabled lints
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
Downgrade new_ret_no_self to pedantic As motivated by rust-lang#5418. This is the second most widely suppressed Clippy style lint, and [this grep.app search](https://grep.app/search?q=%5C%5Ballow%5C%28.%2Aclippy%3A%3Anew_ret_no_self%5Cb®exp=true&case=true&filter[lang][0]=Rust) shows a large number of diverse reasonable signatures for a `new` method. changelog: Remove new_ret_no_self from default set of enabled lints
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
compare with the second largest instead of the smallest variant This should make the lint less noisy for now. See [my comment](rust-lang/rust-clippy#5418 (comment)) to issue rust-lang#5418. --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like I commented in #2043, I can't reproduce the weirdness from #1388 on either mac or linux (x84_64) and pushing to try gives all green.
That's 128 less bytes to have to keep in the stack for every call to __morestack.