Rollup of 13 pull requests #54711
Merged
Rollup of 13 pull requests #54711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the documentation over to `slice::from_raw_parts_mut`.
…t_check_for_mutation_in_guard`
Hitting this branch in Clippy and I think it makes sense to print both values here in case other people hit this branch, too.
Currently we ship sanitizer libraries as they're built, but these names unfortunately conflict with the names of the sanitizer libraries installed on the system. If a crate, for example, links in C code that wants to use the system sanitizer and the Rust code doesn't use sanitizers at all, then using `cargo` may accidentally pull in the Rust-installed sanitizer library due to a conflict in names. This change is intended to be entirely transparent for Rust users of sanitizers, it should only hopefully improve our story with other users! Closes rust-lang#54134
…Jung Document that slices cannot be larger than `isize::MAX` bytes Fixes rust-lang#53676.
Better user experience when attempting to call associated functions with dot notation Closes rust-lang#22692
…ed_crate, r=estebank in which we include attributes in unused `extern crate` suggestion spans  Resolves rust-lang#54400. r? @estebank
…eGomez Indicate how to move value out of Box in docs. Fixes rust-lang#53634.
A few cleanups and minor improvements to rustc/infer - use unwrap_or(_else) where applicable - convert single-branch matches to if-let - use to_owned instead of to_string with string literals - improve vector allocations - readability improvements - miscellaneous minor code improvements
Correct doc for WorkQueue<T>::pop(). The old function doc looks like copy-pasta from WorkQueue::insert(). WorkQueue::pop() does not enqueue nor does it return a boolean false. Doc corrected accordingly.
…hewjasper Improve bug! message for impossible case in Relate Hitting this branch [in Clippy][clippy_issue] and I think it makes sense to print both values here in case other people hit this branch, too. (still have to figure out why this branch is hit) [clippy_issue]: rust-lang/rust-clippy#2831 (comment)
Rename sanitizer runtime libraries on OSX Currently we ship sanitizer libraries as they're built, but these names unfortunately conflict with the names of the sanitizer libraries installed on the system. If a crate, for example, links in C code that wants to use the system sanitizer and the Rust code doesn't use sanitizers at all, then using `cargo` may accidentally pull in the Rust-installed sanitizer library due to a conflict in names. This change is intended to be entirely transparent for Rust users of sanitizers, it should only hopefully improve our story with other users! Closes rust-lang#54134
Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own Fixes rust-lang#49475 r? @Mark-Simulacrum
|
@bors r+ p=10 |
|
📌 Commit 3401db0 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 3401db0 with merge 1e2f78ac02a71a7edd1985c3daaa1fbb99000377... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors retry An error occurred while generating the build script. |
bors
added
S-waiting-on-bors
…shearth Add nightly check for tool_lints warning cc rust-lang#54358 Let's add the nightly check, just in case something prevents a stabilization until 1.31.beta.
…abling-ast-check, r=alexcrichton Remove `-Z disable_ast_check_for_mutation_in_guard` One should use `#![feature(bind_by_move_pattern_guards)]` over `-Z disable_ast_check_for_mutation_in_guard` cc rust-lang#15287
|
📌 Commit 5b08200 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 1, 2018
Rollup of 13 pull requests Successful merges: - #53784 (Document that slices cannot be larger than `isize::MAX` bytes) - #54308 (Better user experience when attempting to call associated functions with dot notation) - #54488 (in which we include attributes in unused `extern crate` suggestion spans) - #54544 (Indicate how to move value out of Box in docs.) - #54623 (Added help message for `impl_trait_in_bindings` feature gate) - #54641 (A few cleanups and minor improvements to rustc/infer) - #54656 (Correct doc for WorkQueue<T>::pop().) - #54674 (update miri) - #54676 (Remove `-Z disable_ast_check_for_mutation_in_guard`) - #54679 (Improve bug! message for impossible case in Relate) - #54681 (Rename sanitizer runtime libraries on OSX) - #54708 (Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own) - #54713 (Add nightly check for tool_lints warning)
|
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 1, 2018
Tested on commit rust-lang/rust@6188c58. Direct link to PR: <rust-lang/rust#54711> 🎉 miri on windows: build-fail → test-pass. 🎉 miri on linux: build-fail → test-pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
isize::MAXbytes #53784 (Document that slices cannot be larger thanisize::MAXbytes)extern cratesuggestion spans #54488 (in which we include attributes in unusedextern cratesuggestion spans)impl_trait_in_bindingsfeature gate #54623 (Added help message forimpl_trait_in_bindingsfeature gate)-Z disable_ast_check_for_mutation_in_guard#54676 (Remove-Z disable_ast_check_for_mutation_in_guard)