Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about parentheses on match (return) #55166

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Conversation

varkor
Copy link
Member

@varkor varkor commented Oct 17, 2018

Fixes #55164.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2018
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2018

📌 Commit 0a858dc has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2018
@varkor
Copy link
Member Author

varkor commented Oct 18, 2018

Just noticed the unused_parens lint should be deny for the test.

@bors r=davidtwco rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2018

📌 Commit 40bba70 has been approved by davidtwco

@davidtwco
Copy link
Member

davidtwco commented Oct 18, 2018

@bors r+ rollup

Oops, GitHub didn't refresh.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2018
Don't warn about parentheses on `match (return)`

Fixes rust-lang#55164.
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2018
Don't warn about parentheses on `match (return)`

Fixes rust-lang#55164.
bors added a commit that referenced this pull request Oct 19, 2018
Rollup of 7 pull requests

Successful merges:

 - #54300 (Updated RELEASES.md for 1.30.0)
 - #55013 ([NLL] Propagate bounds from generators)
 - #55071 (Fix ICE and report a human readable error)
 - #55144 (Cleanup resolve)
 - #55166 (Don't warn about parentheses on `match (return)`)
 - #55169 (Add a `copysign` function to f32 and f64)
 - #55178 (Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut())
@bors bors merged commit 40bba70 into rust-lang:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants