Updated RELEASES.md for 1.30.0 #54300

XAMPPRocky · 2018-09-17T16:45:47Z

cc @rust-lang/release

Centril · 2018-09-17T17:33:22Z

RELEASES.md

+
+Language
+--------
+- [This version marks the release of the 2018 edition of Rust.][54057]


I thought we were releasing Rust 2018 in December?

Technically it's stable on master (soon to be beta)?

See https://internals.rust-lang.org/t/rust-2018-release-schedule-and-extended-beta/8076.
First stable release of Rust 2018 should be in 2018-12-06 according to that.
cc @aturon

Correct, this will be released in December, not part of 1.30. Although this is stable on the beta channel we will back it out at the last minute when branching to the stable channel in October. The Rust 2018 edition will not be usable on stable in the 1.30 release, but it will be usable in the 1.31 release

We should probably reword a bit to reflect this :)

1.30 stable will not have anything stabilized with regards to the edition itself, so we can probably just drop this note.

Centril · 2018-09-17T17:34:10Z

RELEASES.md

+Language
+--------
+- [This version marks the release of the 2018 edition of Rust.][54057]
+- [In the 2018 edition you can now use `crate` visibility keyword.][54057]


We haven't stabilized crate as a visibility modifier.

alexcrichton · 2018-09-17T18:07:10Z

I don't see it mentioned, but macros can now be imported with the module system! Put another way, procedural macros are now enabled on stable in 1.30 along with importing macros via use instead of #[macro_use]

RELEASES.md

petrochenkov · 2018-09-17T18:19:54Z

RELEASES.md

+- [You can now apply the `#[used]` attribute to static items to prevent the
+ compiler from optimising them away even if they appear to be unused.][51363]
+ e.g. `#[used] static FOO: u32 = 1;`
+- [You can now import and reexport macros using the `use` syntax.][50911]


Proc macro definitions (#[proc_macro]/#[proc_macro_attribute]) was stabilized in 1.29 (#52081), but never mentioned in release notes.
In 1.30 there's no reason to be secretive about it, so it can be announced.

Tool attributes (#[rustfmt::skip]) are stabilized in 1.30 (#53459).

"macros" -> "macros from other crates"

+ #[macro_export] macros are now placed into the root module of the crate that defines them (#52234)
+ #[macro_export(local_inner_macros)] is implemented (#51496)

To clarify there is no intent to be secretive about the feature. The first draft of the release notes is always just the PRs merged in the six weeks between the releases editorialised by me, with PRs tagged as relnotes always included.

@petrochenkov Could you perhaps explain when you would use #[macro_export(local_inner_macros)] I understand the problem as laid out in the issue but I don't really know how to explain this to an end user of Rust.

@Aaronepower A lot of crates were written with complex macros prior to this new system, assuming that #[macro_export] macros were always available to them. For example, Diesel has several macros that call inner helper macros, either for the purposes of factoring code, or for #[cfg]ing behavior. With the new system, a macro like __diesel_parse_table! wouldn't be available to table! unless it was explicitly imported by our users, or we put $crate:: in front. The former would be ridiculous, and the latter is incompatible with Rust 2015 users. Hence, this attribute.

RELEASES.md

Mark-Simulacrum · 2018-09-19T15:34:28Z

RELEASES.md

+
+Language
+--------
+- [This version marks the release of the 2018 edition of Rust.][54057]


1.30 stable will not have anything stabilized with regards to the edition itself, so we can probably just drop this note.

Mark-Simulacrum · 2018-09-19T15:35:14Z

RELEASES.md

+- [In the 2018 edition you can now use `crate` visibility keyword.][54057]
+ Equivalent to `pub(crate)`.
+- [You can now use keywords as identifiers using the raw identifiers
+ syntax (`r#`).][53236] e.g. `let r#struct = 2018;`


Can we drop the 2018 from the example? I think it might cause confusion since this feature works on 2015 too I believe.

Mark-Simulacrum · 2018-09-19T19:21:53Z

RELEASES.md

+- [You can now use keywords as identifiers using the raw identifiers
+ syntax (`r#`).][53236] e.g. `let r#struct = 2018;`
+- [Using anonymous parameters in traits is now deprecated with a warning and is
+ a hard error in the 2018 edition.][53272]


Here as well -- 'will be a hard error' would be better wording I think.

Mark-Simulacrum · 2018-09-19T19:23:50Z

RELEASES.md

+
+Cargo
+-----
+- [`cargo run` now works in workspaces.][cargo/5877]


Maybe "doesn't require specifying a package in workspaces"

RELEASES.md

sgrif · 2018-09-21T22:59:57Z

RELEASES.md

+ e.g. `#[used] static FOO: u32 = 1;`
+- [You can now import and reexport macros using the `use` syntax.][50911]
+- [`mod.rs` files are now optional, you can now have `src/foo.rs` and
+ `src/foo/bar.rs` to define module dependencies.][54146]


This sentence is really confusing to me. I'm not sure where bar.rs comes into play here, shouldn't we be comparing it to src/foo/mod.rs?

It's the combination that's new. Before, if you wanted a src/foo/bar.rs module, you also had to use src/foo/mod.rs for its parent. Now the parent can just be src/foo.rs.

RELEASES.md

vitalyd · 2018-09-28T15:05:45Z

RELEASES.md

+
+Compatibility notes
+-------------------
+- [`cfg` attributes and `--cfg` command line flags are now more


The stricter --cfg validation went out in 1.29.

petrochenkov · 2018-09-28T19:27:10Z

1.30 also stabilized crate in paths and extern prelude (i.e. crates passed with --extern and also std and core are added to the prelude) - #54404.

bors · 2018-09-29T15:07:50Z

☔ The latest upstream changes (presumably #54660) made this pull request unmergeable. Please resolve the merge conflicts.

mark-i-m · 2018-09-30T00:53:11Z

RELEASES.md

+- [`cargo doc` now supports `--message-format=json`.][cargo/5878] This is
+ equivalent to calling `rustdoc --error-format=json`.
+- [You can specify which edition to create a project in cargo
+ with `cargo new --edition`.][cargo/5984]


Could you add a note that the only stable option is 2015 until next release?

mark-i-m · 2018-09-30T00:56:02Z

RELEASES.md

+ requirement for the code to work, it will now be inferred.
+- [You can now catch visibility keywords (e.g. `pub`, `pub(crate)`) in macros
+ using the `vis` specifier.][53370]
+- [Non-macros attributes now allow all forms of literals not just


Typo: s/Non-macros/Non-macro/

petrochenkov · 2018-10-01T18:03:36Z

RELEASES.md

+- [You can now use `crate` in paths.][54404] This allows you to refer to the
+ crate root in the path. e.g. `use crate::foo;` refers to `foo` in `src/lib.rs`.
+- [`extern crate` definitions are now optional.][54404] To use a external crate
+ you can simply have `use serde;` and add the `serde` dependency in `Cargo.toml`


use serde; is a part of 2018 edition, so it's not in 1.30 yet and extern crate items are still required for imports.
Stabilized feature(extern_prelude) works only for relative paths (let x = my_crate::Thing();), not imports.
Imports are still relative to the crate root on 2015 edition.

#49789 contains more detailed description and test examples.

bors · 2018-10-08T12:18:09Z

☔ The latest upstream changes (presumably #54865) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2018-10-09T15:59:31Z

RELEASES.md

+ Now you can have `src/foo.rs` and `src/foo/bar.rs` to achieve the same effect.
+- [`rustc` can now infer certain outlives requirements.][53793] e.g. In this
+ example `struct Foo<'a, T: 'a>(&'a T);` you now no longer need the `T: 'a`
+ requirement for the code to work, it will now be inferred.


This needs to be removed as we've backed it out recently due to some bugs.

pietroalbini · 2018-10-17T08:21:49Z

Should we merge this?

XAMPPRocky · 2018-10-17T12:45:26Z

@pietroalbini At the moment it's waiting on a url for the chapter on proc macros, but that can be a seperate PR.

Mark-Simulacrum · 2018-10-17T13:07:56Z

Hm, could we guess what that URL will be and add that? We'll want a beta backport here as well so it'd be good to land this sooner rather than later

XAMPPRocky · 2018-10-17T17:01:28Z

Pinging @steveklabnik

steveklabnik · 2018-10-17T17:14:51Z

This week is really rough for me; I can't afford to dig into it right now. You could look at the book's master and sort it, though. Sorry about that! I can get back to you Monday.

Mark-Simulacrum · 2018-10-17T21:45:23Z

@bors delegate+

bors · 2018-10-17T21:45:24Z

✌️ @Aaronepower can now approve this pull request

XAMPPRocky · 2018-10-18T11:44:32Z

@bors r+

bors · 2018-10-18T11:44:33Z

📌 Commit 518a5a4 has been approved by Aaronepower

pietroalbini · 2018-10-18T11:51:28Z

@bors rollup

@Mark-Simulacrum

Updated RELEASES.md for 1.30.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@ghost

[beta] Rollup backports Merged and approved: * #54300: Updated RELEASES.md for 1.30.0 * #54939: rustdoc: don't prefer dynamic linking in doc tests * #54671: resolve: Scale back hard-coded extern prelude additions on 2015 edition * #55102: resolve: Do not skip extern prelude during speculative resolution r? @ghost

@Mark-Simulacrum

Updated RELEASES.md for 1.30.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

Rollup of 7 pull requests Successful merges: - #54300 (Updated RELEASES.md for 1.30.0) - #55013 ([NLL] Propagate bounds from generators) - #55071 (Fix ICE and report a human readable error) - #55144 (Cleanup resolve) - #55166 (Don't warn about parentheses on `match (return)`) - #55169 (Add a `copysign` function to f32 and f64) - #55178 (Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut())

rust-highfive assigned Mark-Simulacrum Sep 17, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2018

pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Sep 17, 2018

Centril reviewed Sep 17, 2018

View reviewed changes

petrochenkov reviewed Sep 17, 2018

View reviewed changes

RELEASES.md Show resolved Hide resolved

petrochenkov reviewed Sep 17, 2018

View reviewed changes

RELEASES.md Show resolved Hide resolved

petrochenkov reviewed Sep 17, 2018

View reviewed changes

RELEASES.md Show resolved Hide resolved

Mark-Simulacrum reviewed Sep 19, 2018

View reviewed changes

kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2018

steveklabnik mentioned this pull request Sep 21, 2018

Update the book for procedural macros rust-lang/book#1283

Closed

pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 21, 2018

sgrif reviewed Sep 21, 2018

View reviewed changes

tshepang reviewed Sep 24, 2018

View reviewed changes

RELEASES.md Show resolved Hide resolved

vitalyd reviewed Sep 28, 2018

View reviewed changes

mark-i-m reviewed Sep 30, 2018

View reviewed changes

XAMPPRocky force-pushed the master branch 2 times, most recently from fbfec86 to 678fdb7 Compare September 30, 2018 12:05

petrochenkov reviewed Oct 1, 2018

View reviewed changes

Mark-Simulacrum reviewed Oct 9, 2018

View reviewed changes

XAMPPRocky force-pushed the master branch 3 times, most recently from 391118f to ec47df2 Compare October 9, 2018 17:25

Updated RELEASES.md for 1.30.0

518a5a4

XAMPPRocky force-pushed the master branch from ec47df2 to 518a5a4 Compare October 18, 2018 11:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2018

kennytm mentioned this pull request Oct 18, 2018

Rollup of 9 pull requests #55181

Closed

pietroalbini mentioned this pull request Oct 18, 2018

[beta] Rollup backports #55184

Merged

pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 18, 2018

kennytm mentioned this pull request Oct 19, 2018

Rollup of 7 pull requests #55194

Merged

bors merged commit 518a5a4 into rust-lang:master Oct 19, 2018

SimonSapin mentioned this pull request Oct 22, 2018

ICE 'allocation missing in dead_alloc_map' in rustc_mir::interpret when compiling Servo #55223

Closed

Updated RELEASES.md for 1.30.0 #54300

Updated RELEASES.md for 1.30.0 #54300

Conversation

XAMPPRocky commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexcrichton commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sgrif Sep 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petrochenkov commented Sep 28, 2018 • edited Loading

bors commented Sep 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented Oct 8, 2018

Choose a reason for hiding this comment

pietroalbini commented Oct 17, 2018

XAMPPRocky commented Oct 17, 2018

Mark-Simulacrum commented Oct 17, 2018

XAMPPRocky commented Oct 17, 2018

steveklabnik commented Oct 17, 2018

Mark-Simulacrum commented Oct 17, 2018

bors commented Oct 17, 2018

XAMPPRocky commented Oct 18, 2018

bors commented Oct 18, 2018

pietroalbini commented Oct 18, 2018

sgrif Sep 21, 2018 •

edited

Loading

petrochenkov commented Sep 28, 2018 •

edited

Loading