Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize a few secondary macro features #53459

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Conversation

petrochenkov
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2018
@petrochenkov
Copy link
Contributor Author

r? @alexcrichton

@alexcrichton
Copy link
Member

This looks good to me, thanks!

I'll defer to..

r? @nrc

though because I want to make sure the tool_attributes feature is ready to be stabilized.

@bors
Copy link
Contributor

bors commented Aug 21, 2018

☔ The latest upstream changes (presumably #53236) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member

nrc commented Aug 22, 2018

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit 16380232afbe58b780565857533506e56428dfe9 has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2018
@mark-i-m
Copy link
Member

This needs a rebase.

`tool_attributes`, `proc_macro_path_invoc`, partially `proc_macro_gen`
@petrochenkov
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit b34503e has been approved by nrc

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 22, 2018
Stabilize a few secondary macro features

- `tool_attributes` - closes rust-lang#44690
- `proc_macro_path_invoc` - this feature was created due to issues with tool attributes (rust-lang#51277), those issues are now fixed (rust-lang#52841)
- partially `proc_macro_gen` - this feature was created due to issue rust-lang#50504, the issue is now fixed (rust-lang#51952), so proc macros can generate modules. They still can't generate `macro_rules` items though due to unclear hygiene interactions.
@bors
Copy link
Contributor

bors commented Aug 23, 2018

⌛ Testing commit b34503e with merge 9b55e966a9cf8d0a172988866a6a438a8c222c60...

@bors
Copy link
Contributor

bors commented Aug 23, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2018
@kennytm
Copy link
Member

kennytm commented Aug 23, 2018

@bors retry

An error occurred while generating the build script.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2018
@bors
Copy link
Contributor

bors commented Aug 23, 2018

⌛ Testing commit b34503e with merge 827e57c...

bors added a commit that referenced this pull request Aug 23, 2018
Stabilize a few secondary macro features

- `tool_attributes` - closes #44690
- `proc_macro_path_invoc` - this feature was created due to issues with tool attributes (#51277), those issues are now fixed (#52841)
- partially `proc_macro_gen` - this feature was created due to issue #50504, the issue is now fixed (#51952), so proc macros can generate modules. They still can't generate `macro_rules` items though due to unclear hygiene interactions.
@bors
Copy link
Contributor

bors commented Aug 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 827e57c to master...

@bors bors merged commit b34503e into rust-lang:master Aug 23, 2018
flip1995 added a commit to rust-lang/rust-clippy that referenced this pull request Aug 23, 2018
@Havvy
Copy link
Contributor

Havvy commented Aug 29, 2018

Other than that procedural macros can generate modules now (yay!), what else here that's being stabilized and needs to be documented in the reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue: RFC 2103 - attributes for tools
9 participants