-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 19 pull requests #55295
Rollup of 19 pull requests #55295
Commits on Sep 27, 2018
-
rustc: Tweak filenames encoded into metadata
This commit is a fix for rust-lang#54408 where on nightly right now whenever generics are inlined the path name listed for the inlined function's debuginfo is a relative path to the cwd, which surely doesn't exist! Previously on beta/stable the debuginfo mentioned an absolute path which still didn't exist, but more predictably didn't exist. The change between stable/nightly is that nightly is now compiled with `--remap-path-prefix` to give a deterministic prefix to all rustc-generated paths in debuginfo. By using `--remap-path-prefix` the previous logic would recognize that the cwd was remapped, causing the original relative path name of the standard library to get emitted. If `--remap-path-prefix` *wasn't* passed in then the logic would create an absolute path name and then create a new source file entry. The fix in this commit is to apply the "recreate the source file entry with an absolute path" logic a bit more aggresively. If the source file's name was remapped then we don't touch it, but otherwise we always take the working dir (which may have been remapped) and then join it to the file to ensure that we process all relative file names as well. The end result is that the standard library should have an absolute path for all file names in debuginfo (using our `--remap-path-prefix` argument) as it does on stable after this patch. Closes rust-lang#54408
Configuration menu - View commit details
-
Copy full SHA for 63c471e - Browse repository at this point
Copy the full SHA 63c471eView commit details
Commits on Oct 10, 2018
-
update tcp stream documentation
Charles Hathaway committedOct 10, 2018 Configuration menu - View commit details
-
Copy full SHA for c514b62 - Browse repository at this point
Copy the full SHA c514b62View commit details
Commits on Oct 11, 2018
-
Small changes to fix documentation auto compile issues
Charles Hathaway committedOct 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 4530b8c - Browse repository at this point
Copy the full SHA 4530b8cView commit details
Commits on Oct 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7892257 - Browse repository at this point
Copy the full SHA 7892257View commit details -
Configuration menu - View commit details
-
Copy full SHA for e650081 - Browse repository at this point
Copy the full SHA e650081View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8223380 - Browse repository at this point
Copy the full SHA 8223380View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55d2607 - Browse repository at this point
Copy the full SHA 55d2607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47e34a2 - Browse repository at this point
Copy the full SHA 47e34a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bb2980 - Browse repository at this point
Copy the full SHA 7bb2980View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c235cf - Browse repository at this point
Copy the full SHA 6c235cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0830650 - Browse repository at this point
Copy the full SHA 0830650View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e14ffb - Browse repository at this point
Copy the full SHA 7e14ffbView commit details
Commits on Oct 17, 2018
-
AST-borrowck: add separate mem category for thread-locals, as they ar…
…e not quite rvalues (and of course they are not quite statics either). Namely, they *do* have a restricted region (like rvalues), but they also cannot be moved out of (like statics).
Configuration menu - View commit details
-
Copy full SHA for a75f781 - Browse repository at this point
Copy the full SHA a75f781View commit details -
Update existing tests and .stderr files to reflect introduction of th…
…read-local mem category.
Configuration menu - View commit details
-
Copy full SHA for e6e4fe6 - Browse repository at this point
Copy the full SHA e6e4fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d46ce5 - Browse repository at this point
Copy the full SHA 1d46ce5View commit details
Commits on Oct 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1cf94f5 - Browse repository at this point
Copy the full SHA 1cf94f5View commit details
Commits on Oct 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for aa0875a - Browse repository at this point
Copy the full SHA aa0875aView commit details
Commits on Oct 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 655f9d8 - Browse repository at this point
Copy the full SHA 655f9d8View commit details
Commits on Oct 21, 2018
-
submodules: update clippy from 5afdf8b to b1d0343
Changes: ```` new_ret_no_self: add sample from rust-lang#3313 to Known Problems section. Support multiline comments and hopefully fix panic Check for comments in collapsible ifs Resolve ICE in needless range loop lint RIIR update_lints: Update changelog links Rename if_let_redundant_pattern_matching to redundant_pattern_matching Add lint for redundant pattern matching for explicit return boolean Fix issue rust-lang#3322: reword help message for len_zero Simplify manual_memcpy suggestion in some cases Fix dogfood Update known problems for unnecessary_fold RIIR update_lints: Replace lint count in README.md Rename `active_lints` to `usable_lints` Add comment on WalkDir vs. fs::read_dir sort_by -> sort_by_key Some more documentation for clippy_dev Use `WalkDir` to also gather from subdirectories Avoid linting `boxed_local` on trait implementations. Website: Make lint categories linkable Restore clippy_dummy's placeholder name Swap order of methods in `needless_range_loop` suggestion in some cases Revert "Exclude pattern guards from unnecessary_fold lint" Exclude pattern guards from unnecessary_fold lint ````
Configuration menu - View commit details
-
Copy full SHA for 9378705 - Browse repository at this point
Copy the full SHA 9378705View commit details -
The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of collection elements by the item size. This change demonstrates the idea more straightforwardly, without the calculation.
Configuration menu - View commit details
-
Copy full SHA for 0f6e274 - Browse repository at this point
Copy the full SHA 0f6e274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f70096 - Browse repository at this point
Copy the full SHA 9f70096View commit details -
only issue "variant of the expected type" suggestion for enums
Felix S. Klock II pointed out that this suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`). Particularly tender-hearted code-historians may be inclined to show mercy towards the author of rust-lang#43178 on the grounds that it's somewhat confusing that struct field definitions are given in a type called `ty::VariantDef`. Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be easier to read in ignore-whitespace mode (`-w`). Resolves rust-lang#55250.
Configuration menu - View commit details
-
Copy full SHA for b0d3d3b - Browse repository at this point
Copy the full SHA b0d3d3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c675111 - Browse repository at this point
Copy the full SHA c675111View commit details
Commits on Oct 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9f0a352 - Browse repository at this point
Copy the full SHA 9f0a352View commit details -
Reproduce the underlying issue
nll (and thus the algorithm for actual promotion) don't know about some casts anymore
Configuration menu - View commit details
-
Copy full SHA for 0ba1262 - Browse repository at this point
Copy the full SHA 0ba1262View commit details -
If root is not START_BLOCK, `basic_blocks().len() - visited` does not represent their exact size.
Configuration menu - View commit details
-
Copy full SHA for 80a6b73 - Browse repository at this point
Copy the full SHA 80a6b73View commit details -
Add note linking to Rust 2018 path semantics docs.
This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.
Configuration menu - View commit details
-
Copy full SHA for d2baf92 - Browse repository at this point
Copy the full SHA d2baf92View commit details -
Suggest appropriate syntax on missing lifetime specifier in return type
Suggest using `'static` when a lifetime is missing in the return type with a structured suggestion instead of a note.
Configuration menu - View commit details
-
Copy full SHA for e1e52eb - Browse repository at this point
Copy the full SHA e1e52ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0bd69a - Browse repository at this point
Copy the full SHA d0bd69aView commit details -
[review comments] modify test and clean up code
Co-Authored-By: estebank <esteban@kuber.com.ar>
Configuration menu - View commit details
-
Copy full SHA for dd91c8f - Browse repository at this point
Copy the full SHA dd91c8fView commit details -
Fix Rustdoc ICE when checking blanket impls
Fixes rust-lang#55001, rust-lang#54744 Previously, SelectionContext would unconditionally cache the selection result for an obligation. This worked fine for most users of SelectionContext, but it caused an issue when used by Rustdoc's blanket impl finder. The issue occured when SelectionContext chose a ParamCandidate which contained inference variables. Since inference variables can change between calls to select(), it's not safe to cache the selection result - the chosen candidate might not be applicable for future results, leading to an ICE when we try to run confirmation. This commit prevents SelectionContext from caching any ParamCandidate that contains inference variables. This should always be completely safe, as trait selection should never depend on a particular result being cached. I've also added some extra debug!() statements, which I found helpful in tracking down this bug.
Configuration menu - View commit details
-
Copy full SHA for 4f2624c - Browse repository at this point
Copy the full SHA 4f2624cView commit details
Commits on Oct 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fda3326 - Browse repository at this point
Copy the full SHA fda3326View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d960a5 - Browse repository at this point
Copy the full SHA 2d960a5View commit details -
Do some copy editing on the release notes
I was reading through the release notes to find something and noticed some small grammatical and consistency issues.
Configuration menu - View commit details
-
Copy full SHA for 8d6ee8f - Browse repository at this point
Copy the full SHA 8d6ee8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4972bea - Browse repository at this point
Copy the full SHA 4972beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d9231c - Browse repository at this point
Copy the full SHA 3d9231cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f912fda - Browse repository at this point
Copy the full SHA f912fdaView commit details -
Rollup merge of rust-lang#54125 - varkor:less-conservative-uninhabite…
…dness-check, r=nikomatsakis Less conservative uninhabitedness check Extends the uninhabitedness check to structs, non-empty enums, tuples and arrays. Pulled out of rust-lang#47291 and rust-lang#50262. Fixes rust-lang#54586. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 7ee68d7 - Browse repository at this point
Copy the full SHA 7ee68d7View commit details -
Rollup merge of rust-lang#54626 - alexcrichton:dwarf-generics, r=mich…
…aelwoerister rustc: Tweak filenames encoded into metadata This commit is a fix for rust-lang#54408 where on nightly right now whenever generics are inlined the path name listed for the inlined function's debuginfo is a relative path to the cwd, which surely doesn't exist! Previously on beta/stable the debuginfo mentioned an absolute path which still didn't exist, but more predictably didn't exist. The change between stable/nightly is that nightly is now compiled with `--remap-path-prefix` to give a deterministic prefix to all rustc-generated paths in debuginfo. By using `--remap-path-prefix` the previous logic would recognize that the cwd was remapped, causing the original relative path name of the standard library to get emitted. If `--remap-path-prefix` *wasn't* passed in then the logic would create an absolute path name and then create a new source file entry. The fix in this commit is to apply the "recreate the source file entry with an absolute path" logic a bit more aggresively. If the source file's name was remapped then we don't touch it, but otherwise we always take the working dir (which may have been remapped) and then join it to the file to ensure that we process all relative file names as well. The end result is that the standard library should have an absolute path for all file names in debuginfo (using our `--remap-path-prefix` argument) as it does on stable after this patch. Closes rust-lang#54408
Configuration menu - View commit details
-
Copy full SHA for b4df53e - Browse repository at this point
Copy the full SHA b4df53eView commit details -
Rollup merge of rust-lang#54965 - chathaway-codes:update-tcp-stream-d…
…ocs, r=GuillaumeGomez update tcp stream documentation A small styling issue that seemed inconsistent here when compared to other places (such as https://doc.rust-lang.org/beta/std/net/struct.TcpListener.html).
Configuration menu - View commit details
-
Copy full SHA for 6948e8e - Browse repository at this point
Copy the full SHA 6948e8eView commit details -
Rollup merge of rust-lang#55150 - pnkfelix:issues-47215-54797-fix-ice…
…-from-moving-out-of-thread-local-under-ast-borrowck, r=nikomatsakis Do not allow moving out of thread local under ast borrowck AST borrowck failed to prevent moving out of a thread-local static. This was broken. And it also (sometimes?) caused an ICE during drop elaboration. Fix rust-lang#47215 Fix rust-lang#54797
Configuration menu - View commit details
-
Copy full SHA for d3ac7c4 - Browse repository at this point
Copy the full SHA d3ac7c4View commit details -
Rollup merge of rust-lang#55173 - estebank:suggest-static, r=oli-obk
Suggest appropriate syntax on missing lifetime specifier in return type Suggest using `'static` when a lifetime is missing in the return type with a structured suggestion instead of a note. Fix rust-lang#55170.
Configuration menu - View commit details
-
Copy full SHA for 830c6b0 - Browse repository at this point
Copy the full SHA 830c6b0View commit details -
Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis
path suggestions in Rust 2018 should point out the change in semantics Fixes rust-lang#55130. This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for a083070 - Browse repository at this point
Copy the full SHA a083070View commit details -
Rollup merge of rust-lang#55225 - bjorn3:rustc_link, r=cramertj
Move cg_llvm::back::linker to cg_utils This allows it to be reused by alternative codegen backends.
Configuration menu - View commit details
-
Copy full SHA for 84722a4 - Browse repository at this point
Copy the full SHA 84722a4View commit details -
Rollup merge of rust-lang#55245 - matthiaskrgr:clippy, r=nikomatsakis
submodules: update clippy from 5afdf8b to b1d0343 Just a routine update. Changes: ```` new_ret_no_self: add sample from rust-lang#3313 to Known Problems section. Support multiline comments and hopefully fix panic Check for comments in collapsible ifs Resolve ICE in needless range loop lint RIIR update_lints: Update changelog links Rename if_let_redundant_pattern_matching to redundant_pattern_matching Add lint for redundant pattern matching for explicit return boolean Fix issue rust-lang#3322: reword help message for len_zero Simplify manual_memcpy suggestion in some cases Fix dogfood Update known problems for unnecessary_fold RIIR update_lints: Replace lint count in README.md Rename `active_lints` to `usable_lints` Add comment on WalkDir vs. fs::read_dir sort_by -> sort_by_key Some more documentation for clippy_dev Use `WalkDir` to also gather from subdirectories Avoid linting `boxed_local` on trait implementations. Website: Make lint categories linkable Restore clippy_dummy's placeholder name Swap order of methods in `needless_range_loop` suggestion in some cases Revert "Exclude pattern guards from unnecessary_fold lint" Exclude pattern guards from unnecessary_fold lint ````
Configuration menu - View commit details
-
Copy full SHA for 9f33d7e - Browse repository at this point
Copy the full SHA 9f33d7eView commit details -
Rollup merge of rust-lang#55247 - peterjoel:peterjoel-prim-char-doc-e…
…xample, r=joshtriplett Clarified code example in char primitive doc The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of elements in the slice by the item size. This change demonstrates the idea more straightforwardly, without needing a calculation, by just comparing the size of the slices.
Configuration menu - View commit details
-
Copy full SHA for 9687c02 - Browse repository at this point
Copy the full SHA 9687c02View commit details -
Rollup merge of rust-lang#55251 - NieDzejkob:master, r=TimNN
Fix a typo in the documentation of RangeInclusive
Configuration menu - View commit details
-
Copy full SHA for 7f46193 - Browse repository at this point
Copy the full SHA 7f46193View commit details -
Rollup merge of rust-lang#55253 - zackmdavis:some_suggestion, r=pnkfelix
only issue "variant of the expected type" suggestion for enums This suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`). Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be easier to read in [ignore-whitespace mode](rust-lang@b0d3d3b9?w=1). Resolves rust-lang#55250. r? @pnkfelix
Configuration menu - View commit details
-
Copy full SHA for a2f3cc3 - Browse repository at this point
Copy the full SHA a2f3cc3View commit details -
Rollup merge of rust-lang#55254 - rust-lang:clean-two-dots, r=Guillau…
…meGomez Correct trailing ellipsis in name_from_pat r? @GuillaumeGomez
Configuration menu - View commit details
-
Copy full SHA for 9dcdb63 - Browse repository at this point
Copy the full SHA 9dcdb63View commit details -
Rollup merge of rust-lang#55258 - Aaron1011:fix/rustdoc-blanket, r=Gu…
…illaumeGomez Fix Rustdoc ICE when checking blanket impls Fixes rust-lang#55001, rust-lang#54744 Previously, SelectionContext would unconditionally cache the selection result for an obligation. This worked fine for most users of SelectionContext, but it caused an issue when used by Rustdoc's blanket impl finder. The issue occured when SelectionContext chose a ParamCandidate which contained inference variables. Since inference variables can change between calls to select(), it's not safe to cache the selection result - the chosen candidate might not be applicable for future results, leading to an ICE when we try to run confirmation. This commit prevents SelectionContext from caching any ParamCandidate that contains inference variables. This should always be completely safe, as trait selection should never depend on a particular result being cached. I've also added some extra debug!() statements, which I found helpful in tracking down this bug.
Configuration menu - View commit details
-
Copy full SHA for a7362db - Browse repository at this point
Copy the full SHA a7362dbView commit details -
Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung
Configuration menu - View commit details
-
Copy full SHA for 1197831 - Browse repository at this point
Copy the full SHA 1197831View commit details -
Rollup merge of rust-lang#55269 - matthiaskrgr:typos_oct, r=zackmdavis
fix typos in various places
Configuration menu - View commit details
-
Copy full SHA for 21d000c - Browse repository at this point
Copy the full SHA 21d000cView commit details -
Rollup merge of rust-lang#55271 - sinkuu:traversal_iter, r=matthewjasper
Unimplement ExactSizeIterator for MIR traversing iterators If `root` is not `START_BLOCK`, `basic_blocks().len() - visited` does not represent their exact size.
Configuration menu - View commit details
-
Copy full SHA for 3096b4a - Browse repository at this point
Copy the full SHA 3096b4aView commit details -
Rollup merge of rust-lang#55282 - sinkuu:redundant_clone, r=estebank
Remove redundant clone
Configuration menu - View commit details
-
Copy full SHA for 070dcf8 - Browse repository at this point
Copy the full SHA 070dcf8View commit details -
Rollup merge of rust-lang#55285 - integer32llc:release-notes-improvem…
…ents, r=Aaronepower Do some copy editing on the release notes I was reading through the release notes to find something and noticed some small grammatical and consistency issues. I'm happy to revert any of these changes if folks disagree with them!
Configuration menu - View commit details
-
Copy full SHA for 59a0a44 - Browse repository at this point
Copy the full SHA 59a0a44View commit details -
Rollup merge of rust-lang#55291 - kazcw:master, r=nikomatsakis
Update stdsimd submodule Fixes a SSE2 bug. (rust-lang#55249)
Configuration menu - View commit details
-
Copy full SHA for b51c215 - Browse repository at this point
Copy the full SHA b51c215View commit details