Skip to content

publish-toolstate: ping maintainers when a tool builds again #55598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2018
Merged

publish-toolstate: ping maintainers when a tool builds again #55598

merged 1 commit into from
Nov 3, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Nov 1, 2018

And add @Xanewok as an RLS maintainer

r? @kennytm

Motivation is that I see when the RLS gets broken, but have to poll the website to see when it is fixed, I'd prefer to get pinged.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2018
@kennytm
Copy link
Member

kennytm commented Nov 2, 2018

cc @rust-lang/infra, (miri) @oli-obk @RalfJung @eddyb, (clippy) @Manishearth @llogiq @mcarton. I'm going to approve by tomorrow afternoon (in East Asian timezone) if no one minds getting some extra mentions when a tool is fixed.

@kennytm
Copy link
Member

kennytm commented Nov 3, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2018

📌 Commit d0778ac has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 3, 2018
@GuillaumeGomez
Rollup merge of rust-lang#55598 - nrc:tool-bot, r=kennytm
723edf7 
publish-toolstate: ping maintainers when a tool builds again

And add @Xanewok as an RLS maintainer

r? @kennytm

Motivation is that I see when the RLS gets broken, but have to poll the website to see when it is fixed, I'd prefer to get pinged.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 3, 2018
Merged
bors added a commit that referenced this pull request Nov 3, 2018
@bors
Auto merge of #55646 - GuillaumeGomez:rollup, r=GuillaumeGomez
3d28ee3 
Rollup of 5 pull requests

Successful merges:

 - #54162 (Hide default impls items)
 - #55555 (Make `-Z ls` list the actual filename of external dependencies)
 - #55567 (add test for deriving Debug on uninhabited enum)
 - #55568 (test that rustdoc doesn't overflow on a big enum)
 - #55598 (publish-toolstate: ping maintainers when a tool builds again)

Failed merges:

r? @ghost
@bors bors merged commit d0778ac into rust-lang:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrc @kennytm @bors @rust-highfive