-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report failing tests without //~ ERROR
comments
#56244
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me once travis is happy =)
@bors r=nikomatsakis |
📌 Commit ed5b9b626a82ea9e196b5bffc4ce0484245cfd80 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=nikomatsakis |
📌 Commit 3ac2a5285adb2dea1594846017fdb33fee69f592 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
//[astul]~^^^^^ ERROR E0161 | ||
//[nllul]~^^^^^^ ERROR E0161 | ||
//[zflagsul]~^^^^^^^ ERROR E0161 | ||
//[editionul]~^^^^^^^^ ERROR E0161 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh. We really need to implement something where a //~ ERROR
in a revisions test means "this applies to all revisons" ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oli-obk
Why, ^^^^^^
, //~| ERROR
doesn't work with revisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I wish it did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just too lazy to fix it
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
dab4872
to
135cabd
Compare
@bors r=nikomatsakis |
📌 Commit 135cabd69cb2013ec4d6b400dad1ade713782c3d has been approved by |
☔ The latest upstream changes (presumably #49219) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Getting close! 🎉 |
135cabd
to
f0b7d75
Compare
@bors r=nikomatsakis |
📌 Commit f0b7d755b17ab8607e1c487de89bf19ded231ece has been approved by |
f0b7d75
to
69024f6
Compare
@bors r=nikomatsakis |
📌 Commit 69024f65522961301be9f8ed242d6cebf9ded0ee has been approved by |
☔ The latest upstream changes (presumably #56451) made this pull request unmergeable. Please resolve the merge conflicts. |
69024f6
to
ff97569
Compare
@bors r=nikomatsakis |
📌 Commit ff97569 has been approved by |
@bors p=4 Raising priority as this may affect / be affected by many other PRs. |
Report failing tests without `//~ ERROR` comments r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
r? @nikomatsakis