make non_camel_case_types an early lint #57088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 1c0e48302ab491acea9357cad8fd944d4c4e4c01 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- Failed in rollup: #57092 (comment) |
bors
added
S-waiting-on-author
euclio
force-pushed
the
non-camel-case-early-lint
branch
from
1c0e483 to
6474de9
Compare
|
@estebank Whoops, forgot to update the NLL stderr files. Fixed. |
|
@bors r+ |
|
📌 Commit 6474de9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 25, 2018
make non_camel_case_types an early lint This allows us to catch these kinds of style violations much earlier, as evidenced by the large number of tests that had to be updated for this change.
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #57088! Tested on commit 14b9665. 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 25, 2018
Tested on commit rust-lang/rust@14b9665. Direct link to PR: <rust-lang/rust#57088> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
This was referenced Dec 25, 2018
euclio
added a commit
to euclio/rust-clippy
that referenced
this pull request
Dec 25, 2018
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 26, 2018
fix breakage from rust-lang/rust#57088
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 28, 2018
Fixes clippy toolstate Changes: ```` Match on ast/hir::ExprKind::Err Update *.stderr files Use -Zui-testing flag Mention S-inactive-closed PRs in the CONTRIBUTING.md tests: fix formatting and update test output base tests: make sure to fail CI if tests need formatting base tests: switch to nightly toolchain before checking formatting of tests with rustfmt rustup rust-lang#57069 Rustfmt. fix breakage from rust-lang#57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ````
bors
added a commit
that referenced
this pull request
Dec 28, 2018
submodules: update clippy from fc24fce to 721f688 Fixes clippy toolstate. Changes: ```` rustup #57069 Rustfmt. fix breakage from #57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ```` r? @oli-obk
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Fixes clippy toolstate Changes: ```` Match on ast/hir::ExprKind::Err Update *.stderr files Use -Zui-testing flag Mention S-inactive-closed PRs in the CONTRIBUTING.md tests: fix formatting and update test output base tests: make sure to fail CI if tests need formatting base tests: switch to nightly toolchain before checking formatting of tests with rustfmt rustup rust-lang/rust#57069 Rustfmt. fix breakage from rust-lang/rust#57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to catch these kinds of style violations much earlier, as evidenced by the large number of tests that had to be updated for this change.