librustc_save_analysis => 2018 #58233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
taiki-e
commented
Feb 6, 2019
| use json_dumper::{Access, DumpOutput, JsonDumper}; | ||
| use span_utils::SpanUtils; | ||
| use sig; | ||
| use crate::{escape, generated_code, id_from_def_id, id_from_node_id, lower_attributes, |
There was a problem hiding this comment.
id_from_def_id and id_from_node_id are widely used in this module, and different functions with the same name are not used, so they are added to imports.
|
@bors r+ |
|
📌 Commit ba0fbd7 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 8, 2019
…, r=Centril librustc_save_analysis => 2018 Transitions `librustc_save_analysis` to Rust 2018; cc rust-lang#58099 r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 8, 2019
…, r=Centril librustc_save_analysis => 2018 Transitions `librustc_save_analysis` to Rust 2018; cc rust-lang#58099 r? @Centril
bors
added a commit
that referenced
this pull request
Feb 9, 2019
Rollup of 18 pull requests Successful merges: - #58091 (Transition compiletest to Rust 2018) - #58115 (Transition rustdoc to 2018 edition) - #58120 (Transition build_helper to 2018 edition) - #58222 (librustc_allocator => 2018) - #58233 (librustc_save_analysis => 2018) - #58245 (librustc_lint => 2018) - #58247 (librustc_passes => 2018) - #58251 (Transition librustc_traits to 2018 edition) - #58255 (librustc_metadata => 2018) - #58256 (librustc_cratesio_shim => 2018) - #58257 (librustc_target => 2018) - #58259 (librustc_codegen_utils => 2018) - #58260 (librustc_borrowck => 2018) - #58261 (librustc_incremental => 2018) - #58265 (librustc_mir => 2018) - #58275 (libcore, liballoc: disable tests in Miri) - #58285 (error_index_generator => 2018) - #58312 (librustc_data_structures => 2018) Failed merges: r? @ghost
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitions
librustc_save_analysisto Rust 2018; cc #58099r? @Centril