-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #58282
Closed
Closed
Rollup of 15 pull requests #58282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update reference of rlibc crate to compiler-builtins crate None
Transition compiletest to Rust 2018 This transitions `src/tools/compiletest` to Rust 2018. cc rust-lang#58099
Transition rustdoc to 2018 edition Transitions rustdoc to Rust 2018; cc rust-lang#58099
…r=Centril Transition build_helper to 2018 edition Transitions build_helper to Rust 2018; cc rust-lang#58099 r? @Centril
Partially HirId-ify rustc Another step towards rust-lang#57578.
Partially HirIdify mir Another step towards rust-lang#57578.
Partially Hiridify typeck Another step towards rust-lang#57578.
Add Cargo.lock automatically adding message If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099 r? @Centril
HirId-ify hir::BodyId Another step towards rust-lang#57578.
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
…lexcrichton Add embedded book to test such that checktools works r? @alexcrichton FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.
…Centril librustc_allocator => 2018 Transitions `librustc_allocator` to Rust 2018; cc rust-lang#58099 r? @Centril
…, r=Centril librustc_save_analysis => 2018 Transitions `librustc_save_analysis` to Rust 2018; cc rust-lang#58099 r? @Centril
Add #[must_use] message to Fn* traits This PR adds `#[must_use]` message to `Fn*` traits. Related: rust-lang#57549 r? @estebank
…Simulacrum libcore, liballoc: disable tests in Miri I am going to run the libcore and liballoc unit test suites in Miri. Not all tests pass. This PR disables a whole bunch of tests when running in Miri, to get us to a baseline from which I can investigate failures. Cc @SimonSapin @alexcrichton
@bors r+ p=15 |
📌 Commit 4a89289 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Feb 8, 2019
⌛ Testing commit 4a89289 with merge 8255e009c0e3d86bf7ace0e9210ccb0af21d15c9... |
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Feb 8, 2019
Looks like a spurious network failure:
https://ci.appveyor.com/project/rust-lang/rust/builds/22218713/job/eyudermjtanbv5i2#L5793 |
The next few PRs are not quite suitable for rollup, let's try again tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost