Skip to content

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 8, 2019

Transitions librustc_typeck to Rust 2018; cc #58099

TODO: elided_lifetimes_in_paths

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 8, 2019

Any crate that uses TyCtxt more than few times should opt out of elided_lifetimes_in_paths IMO.
TyCtxt<'_, '_, '_> is not the way to go.

@Centril
Copy link
Contributor

Centril commented Feb 8, 2019

@petrochenkov We can leave that change out of this PR cause I just want to get all crates migrated... However, Formatter or TyCxt will become distinctly unidiomatic and hopefully quite deprecated soon and I don't think that rustc should block that.

@Centril
Copy link
Contributor

Centril commented Feb 8, 2019

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned Centril Feb 8, 2019
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 9, 2019

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@petrochenkov petrochenkov changed the title [WIP] librustc_typeck => 2018 librustc_typeck => 2018 Feb 9, 2019
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 9, 2019

📌 Commit fe27623 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril
@pietroalbini
Copy link
Member

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril
bors added a commit that referenced this pull request Feb 12, 2019
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost
@bors bors merged commit fe27623 into rust-lang:master Feb 12, 2019
@taiki-e taiki-e deleted the librustc_typeck-2018 branch February 12, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants