-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 17 pull requests #58338
Rollup of 17 pull requests #58338
Conversation
It is easier and it should be also faster, because `to_ne_bytes` just calls `mem::transmute`.
This is not really significant, accept or reject as you wish. I just want to make sure I understand how the PR process works and I'm doing it right before doing a bigger one for rust-lang#33417.
@bors r+ p=5 |
📌 Commit 817765c89ef4c7822986978a60cd05c6aacf9b8e has been approved by |
⌛ Testing commit 817765c89ef4c7822986978a60cd05c6aacf9b8e with merge e8820cfb1219c8e8835b4b35584f192a0d9f1bfe... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Update reference of rlibc crate to compiler-builtins crate None
817765c
to
c3d2490
Compare
…r=scottmcm Use `to_ne_bytes` for converting IPv4Addr to octets It is easier and it should be also faster, because [`to_ne_bytes`](https://doc.rust-lang.org/std/primitive.u32.html#method.to_ne_bytes) just calls `mem::transmute`.
Tiny expansion to docs for `core::convert`. This is not really significant, accept or reject as you wish. I just want to make sure I understand how the PR process works and that I'm doing it right before doing a bigger one for rust-lang#33417.
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
Add #[must_use] message to Fn* traits This PR adds `#[must_use]` message to `Fn*` traits. Related: rust-lang#57549 r? @estebank
std::sys::unix::stdio: explain why we do into_raw I was quite puzzled why someone would call `into_raw` and then ignore the result.
…isdreavus Cleanup JS a bit r? @QuietMisdreavus
miri: give non-generic functions a stable address This makes Miri correctly handle format string parameters despite rust-lang#58320. Matching Miri PR: rust-lang/miri#626 r? @oli-obk
…r=oli-obk operand-to-place copies should never be overlapping This seems to just work (verified with the Miri test suite). r? @oli-obk
When there are multiple filenames, print what got interpreted as filenames I have written code that crafts command lines for rustc, and when I get "multiple input filenames provided" it can be quite hard to figure out where in this long list of arguments the mistake is hiding. Probably I passed an argument to a flag that does not expect an argument, but which flag would that be? This changes the error message to print the first two filenames, to make it easier to debug what is going on.
rpath computation: explain why we pop() I was quite confused by this code until I got a debug log of what is going on.
Fix failing tidy (line endings on Windows) Updates to `embedded-book` including rust-embedded/book#127.
miri value visitor: use `?` in macro
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
to_ne_bytes
for converting IPv4Addr to octets #57740 (Useto_ne_bytes
for converting IPv4Addr to octets)hir::Expr
. #58258 (Reduce the size ofhir::Expr
.)Failed merges:
r? @ghost