Closure bounds fixes #58347
Merged
Closure bounds fixes #58347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
pnkfelix
reviewed
Feb 11, 2019
| @@ -59,7 +60,7 @@ impl<'cx, 'gcx, 'tcx> NiceRegionError<'cx, 'gcx, 'tcx> { | |||
| self.infcx.tcx | |||
| } | |||
|
|
|||
| pub fn try_report_from_nll(&self) -> Option<ErrorReported> { | |||
| pub fn try_report_from_nll(&self) -> Option<DiagnosticBuilder<'cx>> { | |||
There was a problem hiding this comment.
this (and the corresponding changes to make diagnostic construction lazy here) was smart
|
@bors r+ |
|
📌 Commit 2547c2c85d6736d81846ebf5c45822a6e7cedc65 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
matthewjasper
force-pushed
the
closure-bounds-fixes
branch
from
2547c2c
to
5ebb4e7
Compare
|
@bors r=pnkfelix |
|
📌 Commit 5ebb4e7ef6579c012e925936d0dce198b094190c has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
matthewjasper
force-pushed
the
closure-bounds-fixes
branch
from
5ebb4e7
to
79e8c31
Compare
|
@bors r=pnkfelix |
|
📌 Commit 79e8c31 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 14, 2019
… r=pnkfelix Closure bounds fixes * Ensures that "nice region errors" are buffered so that they are sorted and migrated correctly. * Propagates fewer constraints for closures (cc rust-lang#58178) * Propagate constraints from closures more precisely (rust-lang#58127) Closes rust-lang#58127 r? @nikomatsakis
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 14, 2019
… r=pnkfelix Closure bounds fixes * Ensures that "nice region errors" are buffered so that they are sorted and migrated correctly. * Propagates fewer constraints for closures (cc rust-lang#58178) * Propagate constraints from closures more precisely (rust-lang#58127) Closes rust-lang#58127 r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Feb 14, 2019
Rollup of 7 pull requests Successful merges: - #58309 (Add more profiler events) - #58347 (Closure bounds fixes) - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them) - #58371 (Check user type annotations for range patterns.) - #58378 (rustc: Implement incremental "fat" LTO) - #58407 (specify "upper camel case" in style lint) - #58449 (Notify @topecongiro when the state of rustfmt has changed) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58127
r? @nikomatsakis