Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify "upper camel case" in style lint #58407

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Feb 12, 2019

Also, fix an issue where internal upper case letters were converted to
lower case.

Fixes #57319.

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2019
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, leave it to you to address the actionable comment

src/librustc_lint/nonstandard_style.rs Show resolved Hide resolved
src/test/ui/lint/lint-non-camel-case-types.rs Show resolved Hide resolved
Also, fix an issue where internal upper case letters were converted to
lower case.
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2019

📌 Commit 2f95299 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 14, 2019
specify "upper camel case" in style lint

Also, fix an issue where internal upper case letters were converted to
lower case.

Fixes rust-lang#57319.
bors added a commit that referenced this pull request Feb 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #58309 (Add more profiler events)
 - #58347 (Closure bounds fixes)
 - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them)
 - #58371 (Check user type annotations for range patterns.)
 - #58378 (rustc: Implement incremental "fat" LTO)
 - #58407 (specify "upper camel case" in style lint)
 - #58449 (Notify @topecongiro when the state of rustfmt has changed)

Failed merges:

r? @ghost
@bors bors merged commit 2f95299 into rust-lang:master Feb 14, 2019
@euclio euclio deleted the upper-camel-case branch February 14, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect camel case warning
5 participants