Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more discerning on when to attempt suggesting a comma in a macro invocation #59116

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Be more discerning on when to attempt suggesting a comma in a macro invocation #59116

merged 2 commits into from
Mar 19, 2019

Conversation

estebank
Copy link
Contributor

Fix #58796.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2019
@estebank
Copy link
Contributor Author

r? @petrochenkov

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2019
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2019
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 13, 2019

📌 Commit 27abd52 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 13, 2019
@pietroalbini
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
4f01679 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@pietroalbini pietroalbini mentioned this pull request Mar 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
@Centril
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
4e992e0 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Centril Centril mentioned this pull request Mar 13, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 14, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
58f26bb 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 14, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2019
@Centril
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
e371eef 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Centril Centril mentioned this pull request Mar 16, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2019
@Centril
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
1729852 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Centril Centril mentioned this pull request Mar 16, 2019
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Mar 18, 2019
@sanxiyn
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
f62585f 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@sanxiyn sanxiyn mentioned this pull request Mar 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
@Centril
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
baa344b 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Centril Centril mentioned this pull request Mar 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
@Centril
Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov
8ebe2ac 
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
@Centril Centril mentioned this pull request Mar 19, 2019
Merged
bors added a commit that referenced this pull request Mar 19, 2019
@bors
Auto merge of #59293 - Centril:rollup, r=Centril
7a4df3b 
Rollup of 11 pull requests

Successful merges:

 - #56348 (Add todo!() macro)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57847 (dbg!() without parameters)
 - #58778 (Implement ExactSizeIterator for ToLowercase and ToUppercase)
 - #58812 (Clarify distinction between floor() and trunc())
 - #58939 (Fix a tiny error in documentation of std::pin.)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)
 - #59252 (add self to mailmap)
 - #59275 (Replaced self-reflective explicit types with clearer `Self` or `Self::…` in stdlib docs)
 - #59280 (Stabilize refcell_map_split feature)
 - #59290 (Run branch cleanup after copy prop)

Failed merges:

r? @ghost
@bors bors merged commit 27abd52 into rust-lang:master Mar 19, 2019
@estebank estebank deleted the comma-sugg branch November 9, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @petrochenkov @bors @pnkfelix