Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #59271

Closed
wants to merge 32 commits into from
Closed

Rollup of 8 pull requests #59271

wants to merge 32 commits into from

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Mar 18, 2019

Successful merges:

Failed merges:

r? @ghost

cuviper and others added 30 commits March 6, 2019 20:14
Cargo powerpc64 and powerpc64le are seeing `SIGILL` crashes in openssl,
which was found to be a linking problem, fixed by newer binutils. See
<rust-lang#57345 (comment)>

For powerpc64 we're using crosstool-ng, which doesn't offer a newer
binutils version, but we can just compile it separately. On powerpc64le
we're already building binutils. Both are now updated to binutils 2.32.

Closes rust-lang/cargo#6320
Closes rust-lang#57345
Closes rust-lang/rustup#1620
…);` and potentially instantiated at different types.

(Updated to reflect changes in diagnostic output and compiletest infrastructure.)
…constraints-on-bindings-too, r=nikomatsakis

extra testing of how NLL handles wildcard type `_`

test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings.

(NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.)

cc rust-lang#55748
[CI] Update binutils for powerpc64 and powerpc64le

Cargo powerpc64 and powerpc64le are seeing `SIGILL` crashes in openssl,
which was found to be a linking problem, fixed by newer binutils. See
<rust-lang#57345 (comment)>

For powerpc64 we're using crosstool-ng, which doesn't offer a newer
binutils version, but we can just compile it separately. On powerpc64le
we're already building binutils. Both are now updated to binutils 2.32.

Closes rust-lang/cargo#6320
Closes rust-lang#57345
Closes rust-lang/rustup#1620

r? @alexcrichton
Add peer_addr function to UdpSocket

Fixes rust-lang#59104

This is my first pull request to Rust, so opening early for some feedback.

My biggest question is: where do I add tests?

Any comments very much appreciated!
Be more discerning on when to attempt suggesting a comma in a macro invocation

Fix rust-lang#58796.
use the identifier span for missing struct field
…chenkov

Use a valid name for graphviz graphs

Hiridification has broken graphviz output because `HirId` has a more complex display implemetation than `NodeId`. Since the id was just used to generate a distinct identifier, we just pull out the various constituent indexed.
@sanxiyn
Copy link
Member Author

sanxiyn commented Mar 18, 2019

@bors r+ p=8

@bors
Copy link
Contributor

bors commented Mar 18, 2019

📌 Commit 9dd8cb2 has been approved by sanxiyn

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 18, 2019
@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 9dd8cb2 with merge 49d0d15796d364e86e3df584c75e9efc4106e660...

@bors
Copy link
Contributor

bors commented Mar 18, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:02:25] Questions should be asked at https://answers.launchpad.net/gcc-arm-embedded
[00:02:25] 
[00:02:25] Bug can be filed at https://bugs.launchpad.net/gcc-arm-embedded/+filebug. It is highly encouraged to ask question first before filing a bug.
[00:02:25]  More info: https://launchpad.net/~team-gcc-arm-embedded/+archive/ubuntu/ppa
[00:02:25] gpg: keyring `/tmp/tmpp__52kbn/secring.gpg' created
[00:02:25] gpg: keyring `/tmp/tmpp__52kbn/pubring.gpg' created
[00:02:25] gpg: requesting key F64D33B0 from hkp server keyserver.ubuntu.com
[00:02:25] gpg: /tmp/tmpp__52kbn/trustdb.gpg: trustdb created
[00:02:25] gpg: no ultimately trusted keys found
[00:02:25] gpg: Total number processed: 1
[00:02:25] gpg:               imported: 1  (RSA: 1)
[00:02:25] OK
---
travis_time:end:125d92b2:start=1552908478759766025,finish=1552908478764865955,duration=5099930
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:154fb267
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02059d2e
travis_time:start:02059d2e
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:25c89d08
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2019
@sanxiyn
Copy link
Member Author

sanxiyn commented Mar 18, 2019

It seems to me that the failure is due to #59254.

@sanxiyn sanxiyn closed this Mar 19, 2019
@sanxiyn sanxiyn deleted the rollup branch March 19, 2019 07:57
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.