Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #59165

Closed
wants to merge 31 commits into from
Closed

Rollup of 9 pull requests #59165

wants to merge 31 commits into from

Commits on Mar 5, 2019

  1. Configuration menu
    Copy the full SHA
    7e8758b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Configuration menu
    Copy the full SHA
    967e7f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. Configuration menu
    Copy the full SHA
    d320b4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18d6c6e View commit details
    Browse the repository at this point in the history
  3. syntax_ext: Validate #[proc_macro_derive] input better

    Tweak some error wording
    petrochenkov committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    f3b8809 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d90794 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e81535c View commit details
    Browse the repository at this point in the history
  6. Refactor away NestedMetaItemKind

    Remove methods `Attribute::span` and `MetaItem::span` duplicating public fields
    petrochenkov committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    98de9b7 View commit details
    Browse the repository at this point in the history
  7. Fix rebase

    petrochenkov committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    bfb200d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Configuration menu
    Copy the full SHA
    e25df32 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35c19c5 View commit details
    Browse the repository at this point in the history
  3. fix tests

    newpavlov committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    980871a View commit details
    Browse the repository at this point in the history
  4. fix test

    newpavlov authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    197efb0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b9d12ed View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. fix typo

    newpavlov authored Mar 12, 2019
    Configuration menu
    Copy the full SHA
    78b248d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    795d307 View commit details
    Browse the repository at this point in the history
  3. review comments

    estebank committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    f923476 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Make std time tests more robust for platform differences

    Jethro Beekman committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    adbd0a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ea9b58 View commit details
    Browse the repository at this point in the history
  3. Fix operator precedence

    estebank committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    27abd52 View commit details
    Browse the repository at this point in the history
  4. Add test for rust-lang#55809.

    This commit adds a regression test for rust-lang#55809 which checks that a
    overflow does not occur when evaluating a requirement for async
    functions and `&mut` arguments in some specific circumstances.
    davidtwco committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    9d938f6 View commit details
    Browse the repository at this point in the history
  5. Fix generic argument lookup for Self

    Rewrite the SelfCtor early and use the replacement Def when
    calculating the path_segs.
    
    Note that this also changes which def is seen by the code that
    computes user_self_ty and is_alias_variant_ctor; I don't see a
    immediate issue with that, but I'm not 100% clear on the
    implications.
    
    Fixes rust-lang#57924
    Angelos Oikonomopoulos committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    311025e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#58789 - jordanrh1:update-compiler-builtins,…

    … r=sanxiyn
    
    Update compiler_builtins to 0.1.7 to get windows/arm fix
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    9758d97 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#58899 - petrochenkov:derval2, r=estebank

    Do not accidentally treat multi-segment meta-items as single-segment
    
    Fixes rust-lang#55168 and many other regressions from rust-lang#50030
    
    Basically, attributes like `#[any::prefix::foo]` were commonly interpreted as `#[foo]` due to `name()` successfully returning the last segment (this applies to nested things as well `#[attr(any::prefix::foo)]`).
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    80049d9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#59025 - aoikonomopoulos:issue-57924, r=varkor

    Fix generic argument lookup for Self
    
    Rewrite the SelfCtor early and use the replacement Def when
    calculating the path_segs.
    
    Note that this also changes which def is seen by the code that
    computes user_self_ty and is_alias_variant_ctor; I don't see a
    immediate issue with that, but I'm not 100% clear on the
    implications.
    
    Fixes rust-lang#57924
    
    r? @eddyb
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    d263029 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#59047 - petrochenkov:modnodefid, r=Centril

    resolve: Account for new importable entities
    
    Fixes the ICE encountered in rust-lang#58837
    r? @Centril
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    f5138a9 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#59102 - newpavlov:duration_float, r=alexcri…

    …chton
    
    Consistent naming for duration_float methods and additional f32 methods
    
    `duration_float` tracking issue: rust-lang#54361
    
    New list of methods:
    - `as_secs_f64(&self) -> f64`
    - `as_secs_f32(&self) -> f32`
    - `from_secs_f64(secs: f64) -> Duration`
    - `from_secs_f32(secs: f32) -> Duration`
    - `mul_f64(self, rhs: f64) -> Duration`
    - `mul_f32(self, rhs: f32) -> Duration`
    - `div_f64(self, rhs: f64) -> Duration`
    - `div_f32(self, rhs: f64) -> Duration`
    - `div_duration_f64(self, rhs: Duration) -> f64`
    - `div_duration_f32(self, rhs: Duration) -> f32`
    
    With [`num_traits::Float`](https://docs.rs/num-traits/0.2.6/num_traits/float/trait.Float.html) we could've reduced number of methods by factor of two, but unfortunately it's not part of `std`.
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    7787734 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#59116 - estebank:comma-sugg, r=petrochenkov

    Be more discerning on when to attempt suggesting a comma in a macro invocation
    
    Fix rust-lang#58796.
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    4e992e0 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#59146 - estebank:suggest-return-lt, r=varkor

    Suggest return lifetime when there's only one named lifetime
    
    Fix rust-lang#29094.
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    156fec0 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#59147 - jethrogb:jb/time-tests, r=sfackler

    Make std time tests more robust for platform differences
    
    Previously, `time::tests::since_epoch` and `time::tests::system_time_math` would fail if the platform represents a SystemTime as unix epoch + `u64` nanoseconds.
    
    r? @sfackler
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    353740d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#59156 - davidtwco:issue-55809, r=nikomatsakis

    [wg-async-await] Add regression test for rust-lang#55809.
    
    Fixes rust-lang#55809.
    
    This PR adds a regression test for rust-lang#55809 which checks that a
    overflow does not occur when evaluating a requirement for async
    functions and `&mut` arguments in some specific circumstances.
    Centril authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    3569af1 View commit details
    Browse the repository at this point in the history