Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn HIR lowering into a query #59205

Closed
wants to merge 4 commits into from
Closed

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 15, 2019

Builds on #59064.

r? @michaelwoerister

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2019
@Zoxc Zoxc marked this pull request as ready for review March 15, 2019 10:41
@Zoxc Zoxc changed the title Turn HIR lowering into a query [WIP] Turn HIR lowering into a query Mar 15, 2019
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from ba4c7ea to 7c39053 Compare March 15, 2019 12:16
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from 7c39053 to 74b1b48 Compare March 15, 2019 12:38
@Zoxc Zoxc mentioned this pull request Mar 15, 2019
@rust-highfive

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

☔ The latest upstream changes (presumably #58140) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from 74b1b48 to fa6e22e Compare March 18, 2019 12:48
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch 2 times, most recently from 128a05b to 333d1ac Compare March 18, 2019 16:46
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from f021021 to a05ed38 Compare March 19, 2019 10:09
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from a05ed38 to 29ae535 Compare March 19, 2019 12:52
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from 29ae535 to fae8407 Compare March 19, 2019 16:19
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from fae8407 to a029f64 Compare March 19, 2019 17:25
@rust-highfive

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from a029f64 to 14dc3c6 Compare March 19, 2019 21:03
@Zoxc Zoxc force-pushed the query-hir-lowering branch from feab4e7 to a3dd75d Compare April 9, 2019 09:36
@bors

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from a3dd75d to 0ca3a92 Compare April 13, 2019 12:26
@bors

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from 0ca3a92 to 9626842 Compare April 24, 2019 15:37
@bors

This comment has been minimized.

@Zoxc Zoxc force-pushed the query-hir-lowering branch from 9626842 to 7099d33 Compare May 5, 2019 09:18
@bors
Copy link
Collaborator

bors commented May 6, 2019

☔ The latest upstream changes (presumably #60567) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum Mark-Simulacrum added S-blocked-closed and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@Mark-Simulacrum
Copy link
Member

Visiting from triage, I'm closing the series of PRs here other than the first one since they will likely only make progress sequentially and it doesn't help to have all of them open. For reference, this is blocked on #59064.

Feel free to reopen as that PR merges and/or makes progress.

@Zoxc Zoxc reopened this Jun 18, 2019
@Zoxc Zoxc force-pushed the query-hir-lowering branch 2 times, most recently from be56785 to 744ed04 Compare June 18, 2019 22:27
@jonas-schievink jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked-closed labels Jun 22, 2019
@Zoxc Zoxc force-pushed the query-hir-lowering branch from 744ed04 to 9504524 Compare June 27, 2019 11:40
@Zoxc Zoxc force-pushed the query-hir-lowering branch from 9504524 to a7c010d Compare July 8, 2019 14:21
@Mark-Simulacrum Mark-Simulacrum added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2019
@Zoxc Zoxc closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants