Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn parsing into a query #59338

Closed
wants to merge 8 commits into from
Closed

Turn parsing into a query #59338

wants to merge 8 commits into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 21, 2019

Builds on #59282.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc Zoxc mentioned this pull request Mar 24, 2019
Closed
@Zoxc Zoxc changed the title [WIP] Turn parsing into a query Turn parsing into a query Mar 25, 2019
@Zoxc Zoxc force-pushed the query-parsing branch 2 times, most recently from 1c5fd86 to 201f386 Compare March 26, 2019 22:08
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the query-parsing branch 2 times, most recently from 6de4662 to 17dde63 Compare April 2, 2019 18:49
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Dylan-DPC-zz
Copy link

r? @michaelwoerister

@Mark-Simulacrum Mark-Simulacrum added S-blocked-closed and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 18, 2019 •
edited
Loading

Visiting from triage, I'm closing the series of PRs here other than the first one since they will likely only make progress sequentially and it doesn't help to have all of them open. For reference, this is #59282, and #59205 which are (in that order) blocked on each other and eventually #59064.

Feel free to reopen as those PRs merge and/or make progress.

This was referenced May 18, 2019
Closed
Closed
@Zoxc Zoxc reopened this Jun 18, 2019
@bors
Copy link
Contributor

bors commented Jun 22, 2019

☔ The latest upstream changes (presumably #62041) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2019
@rholderfield
Copy link

ping from triage... @Zoxc, can you please provide a status?

@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Aug 3, 2019
@JohnCSimon
Copy link
Member

@Zoxc Ping from triage - unfortunately this has sat idle for too long and I'm going to have to close this.
Feel free to re-open when you get back to this.

@JohnCSimon JohnCSimon closed this Aug 3, 2019
@nnethercote nnethercote mentioned this pull request Aug 30, 2019
Merged
@pnkfelix pnkfelix mentioned this pull request Sep 17, 2019
Closed
@jyn514 jyn514 added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Zoxc @rust-highfive @bors @Dylan-DPC-zz @Mark-Simulacrum @rholderfield @JohnCSimon @eddyb @michaelwoerister @jyn514